Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix range count config #827

Merged
merged 1 commit into from
Mar 20, 2021
Merged

fix range count config #827

merged 1 commit into from
Mar 20, 2021

Conversation

MaxBenChrist
Copy link
Collaborator

No description provided.

@MaxBenChrist
Copy link
Collaborator Author

I was thinking about somehow defining validators for each feature calculator. (e.g. range_count parameter should have min<max)

However, that would be a costly operation, it should not be done during extraction but somehow before. Maybe we can define some attributes on the feature calculator that are collected before extraction. and then before extraction, we could validate the extraction config

@codecov-io
Copy link

codecov-io commented Mar 18, 2021

Codecov Report

Merging #827 (5f69b50) into main (91a5dc3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files          18       18           
  Lines        1841     1841           
  Branches      362      362           
=======================================
  Hits         1766     1766           
  Misses         37       37           
  Partials       38       38           
Impacted Files Coverage Δ
tsfresh/feature_extraction/settings.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a5dc3...5f69b50. Read the comment docs.

@nils-braun
Copy link
Collaborator

Why would you think that this is costly? I guess most of the checks will be simple comparison operations, or?
In principal I am fine with your changes - thanks!

@MaxBenChrist MaxBenChrist merged commit 26af836 into main Mar 20, 2021
@MaxBenChrist MaxBenChrist deleted the fix_range_settings branch March 20, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants