Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply python package "black" to tsfresh repo #871

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Apply python package "black" to tsfresh repo #871

merged 1 commit into from
Jul 8, 2021

Conversation

mendel5
Copy link
Contributor

@mendel5 mendel5 commented Jul 1, 2021

Related to

I applied the python package black to the tsfresh repository.

This is the output from my terminal:

$ black tsfresh/
reformatted tsfresh/tests/integrations/examples/test_har_dataset.py
reformatted tsfresh/tests/integrations/test_bindings.py
reformatted tsfresh/tests/benchmark.py
reformatted tsfresh/tests/integrations/examples/test_robot_execution_failures.py
reformatted tsfresh/docs/conf.py
reformatted tsfresh/tests/integrations/test_full_pipeline.py
reformatted tsfresh/tests/integrations/test_notebooks.py
reformatted tsfresh/tests/integrations/examples/test_driftbif_simulation.py
reformatted tsfresh/tests/integrations/test_relevant_feature_extraction.py
reformatted tsfresh/tests/units/feature_selection/test_checks.py
reformatted tsfresh/tests/integrations/test_feature_extraction.py
reformatted tsfresh/tests/units/feature_selection/test_fdr_control.py
reformatted tsfresh/tests/fixtures.py
reformatted tsfresh/tests/units/feature_extraction/test_settings.py
reformatted tsfresh/tests/units/feature_extraction/test_extraction.py
reformatted tsfresh/tests/units/scripts/test_run_tsfresh.py
reformatted tsfresh/tests/units/feature_selection/test_significance_tests.py
reformatted tsfresh/tests/units/transformers/test_feature_augmenter.py
reformatted tsfresh/tests/units/feature_selection/test_relevance.py
reformatted tsfresh/tests/units/utilities/test_string_manipilations.py
reformatted tsfresh/tsfresh/__init__.py
reformatted tsfresh/tests/units/feature_selection/test_feature_significance.py
reformatted tsfresh/tests/units/feature_extraction/test_data.py
reformatted tsfresh/tsfresh/examples/__init__.py
reformatted tsfresh/tsfresh/convenience/bindings.py
reformatted tsfresh/tests/units/transformers/test_relevant_feature_augmenter.py
reformatted tsfresh/tests/units/transformers/test_per_column_imputer.py
reformatted tsfresh/tsfresh/feature_extraction/__init__.py
reformatted tsfresh/tsfresh/convenience/relevant_extraction.py
reformatted tsfresh/tsfresh/examples/har_dataset.py
reformatted tsfresh/tests/units/utilities/test_distribution.py
reformatted tsfresh/tsfresh/examples/robot_execution_failures.py
reformatted tsfresh/tsfresh/examples/driftbif_simulation.py
reformatted tsfresh/tsfresh/feature_extraction/extraction.py
reformatted tsfresh/tsfresh/feature_selection/significance_tests.py
reformatted tsfresh/tsfresh/scripts/run_tsfresh.py
reformatted tsfresh/tsfresh/scripts/test_timing.py
reformatted tsfresh/tsfresh/feature_extraction/data.py
reformatted tsfresh/tsfresh/scripts/measure_execution_time.py
reformatted tsfresh/tsfresh/transformers/feature_augmenter.py
reformatted tsfresh/tsfresh/transformers/per_column_imputer.py
reformatted tsfresh/tsfresh/feature_extraction/settings.py
reformatted tsfresh/tsfresh/utilities/profiling.py
reformatted tsfresh/tsfresh/utilities/string_manipulation.py
reformatted tsfresh/tsfresh/transformers/relevant_feature_augmenter.py
reformatted tsfresh/tsfresh/utilities/distribution.py
reformatted tsfresh/tsfresh/utilities/dataframe_functions.py
reformatted tsfresh/tests/units/utilities/test_dataframe_functions.py
reformatted tsfresh/tests/units/feature_extraction/test_feature_calculations.py
reformatted tsfresh/tsfresh/feature_extraction/feature_calculators.py
All done! ✨ 🍰 ✨
50 files reformatted, 21 files left unchanged.

Please review and also have a look at this image.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #871 (46a6735) into main (44fdeb5) will not change coverage.
The diff coverage is 95.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   95.34%   95.34%           
=======================================
  Files          18       18           
  Lines        1867     1867           
  Branches      368      368           
=======================================
  Hits         1780     1780           
  Misses         47       47           
  Partials       40       40           
Impacted Files Coverage Δ
tsfresh/convenience/bindings.py 56.00% <66.66%> (ø)
tsfresh/utilities/distribution.py 88.99% <84.61%> (ø)
tsfresh/feature_selection/significance_tests.py 94.28% <90.00%> (ø)
tsfresh/utilities/dataframe_functions.py 95.83% <93.10%> (ø)
tsfresh/feature_extraction/data.py 95.09% <94.44%> (ø)
tsfresh/convenience/relevant_extraction.py 95.65% <100.00%> (ø)
tsfresh/feature_extraction/extraction.py 95.06% <100.00%> (ø)
tsfresh/feature_extraction/feature_calculators.py 97.60% <100.00%> (ø)
tsfresh/feature_extraction/settings.py 100.00% <100.00%> (ø)
tsfresh/scripts/run_tsfresh.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fdeb5...46a6735. Read the comment docs.

@mendel5
Copy link
Contributor Author

mendel5 commented Jul 7, 2021

Hi @MaxBenChrist and @nils-braun , did you already take a look at this?

@nils-braun
Copy link
Collaborator

Hi @mendel5! Thanks for the PR, the nice image (I like!) and for the second ping.

Your changes do look good, but interfere a bit with the pycodestyle we already have. That is not a big issue and I will try to incorporate "black" into the automatic style checking next. This PR is ready for merging!

@nils-braun nils-braun merged commit 84ec039 into blue-yonder:main Jul 8, 2021
@mendel5
Copy link
Contributor Author

mendel5 commented Jul 10, 2021

This PR is ready for merging!

Thanks!

Your changes do look good, but interfere a bit with the pycodestyle we already have. That is not a big issue and I will try to incorporate "black" into the automatic style checking next.

Is this the same thing you mentioned here before? See:

I can help you with implementing a git-hooks setting for black (and, while doing so, maybe even isort).

How can I help with this? Please tell me!

@nils-braun
Copy link
Collaborator

Sorry, I was too quick :-(

Please see the referenced PR.
All i did was to install pre-commit and add some configuration. With that, all developers of tsfresh will automatically use the correct styling etc. while committing.

@mendel5
Copy link
Contributor Author

mendel5 commented Jul 13, 2021

Sorry, I was too quick :-(

No worries, it's okay.

Please see the referenced PR.

I will close the original issue at #820 now.

If you need anything else from me, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants