Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(state): avoid cloning full account #1097

Merged
merged 2 commits into from
Feb 16, 2024
Merged

perf(state): avoid cloning full account #1097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f81671
perf(state): avoid cloning full account
rkrasiuk Feb 16, 2024
ab8a68c
fix
rkrasiuk Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/revm/src/db/states/cache_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ impl CacheAccount {

/// Fetch account info if it exist.
pub fn account_info(&self) -> Option<AccountInfo> {
self.account.clone().map(|a| a.info)
self.account.as_ref().map(|a| a.info.clone())
}

/// Dissolve account into components.
Expand Down Expand Up @@ -282,7 +282,7 @@ impl CacheAccount {
storage: StorageWithOriginalValues,
) -> TransitionAccount {
let previous_status = self.status;
let previous_info = self.account.clone().map(|a| a.info);
let previous_info = self.account.as_ref().map(|a| a.info.clone());
let mut this_storage = self
.account
.take()
Expand All @@ -303,7 +303,7 @@ impl CacheAccount {
self.account = Some(changed_account);

TransitionAccount {
info: self.account.clone().map(|a| a.info),
info: self.account.as_ref().map(|a| a.info.clone()),
status: self.status,
previous_info,
previous_status,
Expand Down
Loading