Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): Propagate fatal error #1116

Merged
merged 12 commits into from
Feb 21, 2024
Merged

chore(refactor): Propagate fatal error #1116

merged 12 commits into from
Feb 21, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Feb 21, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Valgrind Results:

==3904== Cachegrind, a cache and branch-prediction profiler
==3904== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3904== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3904== Command: target/release/snailtracer
==3904== 
--3904-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==3904== 
==3904== I   refs:      463,578,419
==3904== I1  misses:          3,516
==3904== LLi misses:          2,954
==3904== I1  miss rate:        0.00%
==3904== LLi miss rate:        0.00%
==3904== 
==3904== D   refs:      237,186,963  (160,464,410 rd   + 76,722,553 wr)
==3904== D1  misses:        351,114  (    210,571 rd   +    140,543 wr)
==3904== LLd misses:        137,590  (      4,055 rd   +    133,535 wr)
==3904== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==3904== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3904== 
==3904== LL refs:           354,630  (    214,087 rd   +    140,543 wr)
==3904== LL misses:         140,544  (      7,009 rd   +    133,535 wr)
==3904== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita
Copy link
Member Author

rakita commented Feb 21, 2024

3% less instructions

@rakita rakita marked this pull request as ready for review February 21, 2024 16:08
@rakita rakita merged commit 2d4fb06 into main Feb 21, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
@rakita rakita deleted the refactor_fatal_error branch February 21, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant