-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restrict ContextPrecompiles only to EvmContext #1174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind Results:
|
mattsse
reviewed
Mar 8, 2024
mattsse
approved these changes
Mar 8, 2024
Merged
mattsse
added a commit
to paradigmxyz/revm-inspectors
that referenced
this pull request
Mar 8, 2024
blocked by bluealloy/revm#1174 the `GethDefaultTracingOptions` dont have any effect on the call and prestate tracer this adds special functions for those tracers. The prestate tracer can be simplified entirely and doesn't even have to be a tracer I think, but need to handle that separately
fubuloubu
pushed a commit
to ApeWorX/revm
that referenced
this pull request
Apr 11, 2024
* first stage move Precompiles inside EvmContext. Create InnerEvmContext * Move precompiles and split InnerEvmContext to its file * fix optimism, fmt and clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making context precompiles take full context (External and Evm) would make a problem in Inspector
On main we have moved Precompiles from EvmContext and Inspector would not have access to it, this would break foundry and other tracers.
This PR make Context precompile access only EvmContext and makes no changes to Inspector.
EvmContext is now:
and it implemented
Deref
andDerefMut
oninner