-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional nonce check #1195
Conversation
The failing test is also present on |
This pattern is going to be removed in future. Would create a handler register that overrides the validation handler and sets Env nonce to the expected value: revm/crates/revm/src/handler/mainnet/validation.rs Lines 17 to 36 in 69e3a28
In the future you can expect most of those features to be removed, as the same result can be done with handler register. But as handler register are still new, would be okay to include this now. Up to you, how would you want to proceed? |
As we need this for a bug fix in Hardhat, I'd appreciate if we can use this approach for now. |
btw you would get the same result if you set |
approving this as temporary fix. |
That's good to know. That's just as easy a fix, actually. Thanks! |
The ability to set the Apologies; I should've realised. |
* Revert "feat: optional nonce check (bluealloy#1195)" This reverts commit fe841be. * typo
For Hardhat we need the ability to disable nonce checks. This PR follows the existing pattern for similar features and adds it to the
dev
feature flag.