Improve EthersDB
#1208
Merged
Improve EthersDB
#1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite(kinda) `new` function. - Add `set_block_number` function. - Move `block_on` function to separate module. Add `utils` module.
|
@rakita Why it fails to pass tests. it build successfully |
|
Don't spill the tokio outside the ethersdb as it is behind the feature flag. it fails as it want to build it as |
rakita
reviewed
Mar 19, 2024
This was referenced Mar 22, 2024
Closed
Closed
Closed
Merged
fubuloubu
pushed a commit
to ApeWorX/revm
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve EthersDB:
newfunction.set_block_numberfunction.asyncblocks.Why i need to re-create
EthersDBinstance?Your node will not querying data 10 minutes old. more info here.
Also im fan of reuse memory, memory are cheap but i prefer to not waste it nor re-create instance.
example of the error:
JsonRpcError { code: -32000, message: "error: missing trie node cd677575d733d1d9478ca4c8af9fc9991d98487964f595750c14a3675c1c86db (path 08) <nil>", data: None })