Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the negative test vectors that surfaced some issues in the EIP-2537 implementation. The issue was that the
blst_fp_from_bendian
method did not check that theblst_fp
orblst_fp2
is canonical. There does not seem to be any method in blst for checking this, so instead we convert to big-endian again, checking that the input equals the re-encoded field element.Finding a better way to do this would be highly appreciated.
This is encapsulated into
check_canonical_fp
andcheck_canonical_fp2
.After this change, the positive and negative test vectors from the EIP pass.