Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eof): EOFCREATE spend gas and apply 63/64 rule #1471

Merged
merged 1 commit into from
May 31, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented May 31, 2024

Need to apply 63/64 rule:
execute the container and deduct gas for execution. The 63/64th rule from EIP-150 applies.

and spend all gas that is send

@rakita rakita force-pushed the rakita/eof/fix_eofcreate_gasspend branch from 2b27d5b to 493255d Compare May 31, 2024 13:14
@rakita rakita changed the base branch from rakita/eof/last_frameresult_for_eof to main May 31, 2024 13:21
@rakita rakita force-pushed the rakita/eof/fix_eofcreate_gasspend branch from 493255d to 5ce189f Compare May 31, 2024 13:22
@rakita rakita merged commit fadf6fb into main May 31, 2024
24 checks passed
Copy link
Contributor

Valgrind Results:

==3932== Cachegrind, a cache and branch-prediction profiler
==3932== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3932== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3932== Command: target/release/snailtracer
==3932== 
--3932-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.822005891s
==3932== 
==3932== I   refs:      429,375,345
==3932== I1  misses:          3,254
==3932== LLi misses:          2,808
==3932== I1  miss rate:        0.00%
==3932== LLi miss rate:        0.00%
==3932== 
==3932== D   refs:      206,206,203  (133,651,433 rd   + 72,554,770 wr)
==3932== D1  misses:        344,721  (    204,654 rd   +    140,067 wr)
==3932== LLd misses:        137,613  (      4,261 rd   +    133,352 wr)
==3932== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3932== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3932== 
==3932== LL refs:           347,975  (    207,908 rd   +    140,067 wr)
==3932== LL misses:         140,421  (      7,069 rd   +    133,352 wr)
==3932== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@github-actions github-actions bot mentioned this pull request May 31, 2024
@rakita rakita deleted the rakita/eof/fix_eofcreate_gasspend branch June 1, 2024 12:54
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants