Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helpers for working with instruction tables #1493

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

DaniPopes
Copy link
Collaborator

@DaniPopes DaniPopes commented Jun 6, 2024

Add helpers to InstructionTables for inserting and updating instructions into it.

No functional changes intended.

Better reviewed with whitespace disabled.

@DaniPopes DaniPopes force-pushed the instruction-table-helpers branch 4 times, most recently from 24551eb to 32e2830 Compare June 6, 2024 19:52
#[inline]
pub fn update_boxed_instruction<'a, H, F>(instruction: &mut BoxedInstruction<'a, H>, f: F)
where
H: Host + ?Sized + 'a,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we needs 'a here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can't really see how to remove it

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@rakita rakita merged commit 733bf5e into bluealloy:main Jun 10, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2024
@DaniPopes DaniPopes deleted the instruction-table-helpers branch June 10, 2024 13:10
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants