-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add ReentrancySentryOOG for SSTORE #1795
Conversation
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't strive to port all geth errors as return codes are not part of consensus and it does not make sense.
But I support this PR, as it cleans up sstore_cost and clarifies the logic flow.
One missing thing in comment, but lgtm
Signed-off-by: jsvisa <delweng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Return a detailed OOG error, require bluealloy/revm#1795 to be released first. ref ethereum/go-ethereum#29354 --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Return a detailed OOG error, require bluealloy/revm#1795 to be released first. ref ethereum/go-ethereum#29354 --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Currently reth's trace results
Geth returns a special oog error when gasleft in sstore < 2300, https://github.com/ethereum/go-ethereum/blob/564b6161637fe7e7c28e7c10a1f1978a22861bd2/core/vm/gas_table.go#L184-L188,
so the trace result of reth's is differ to geth's, eg this tx: https://etherscan.io/tx/0x87a19142a638f981a923a6b76859cd4a6d443c430435a1aedf5c9cb35c955768
diff as below:
![image](https://private-user-images.githubusercontent.com/3627395/369948459-0e44325c-aa0d-4c4a-a11f-e30d11fe1dd6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3MTYyODksIm5iZiI6MTczOTcxNTk4OSwicGF0aCI6Ii8zNjI3Mzk1LzM2OTk0ODQ1OS0wZTQ0MzI1Yy1hYTBkLTRjNGEtYTExZi1lMzBkMTFmZTFkZDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTZUMTQyNjI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWRlYThhZWExOGUzYmQyY2M0Njc3NDhiNWJhNzg2ZTY5NTYzMTcwYzY4MjAyYzA5OGRlZjVkODMzMDkwNGM0ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.p7c5EZrvsEJkiH0_zUH4edDPMCW2pqr1z_VZGv75Wgw)