Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eip 1153 #276

Closed
wants to merge 2 commits into from
Closed

feat: eip 1153 #276

wants to merge 2 commits into from

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Nov 22, 2022

EIP-1153 is now CFI for Shanghai. I prototyped an implementation that I'd like to test with in foundry. If the implementation was cleaned up, would you consider this for merge?

@rakita
Copy link
Member

rakita commented Nov 25, 2022

I am surprised it is this simple and congrats on moving the point and making EIP-1153 CFI.
There is 4 CFI atm, it still needs to be decided what is going in, I will wait for that decision.

@tynes
Copy link
Contributor Author

tynes commented Nov 26, 2022

@rakita
Copy link
Member

rakita commented Feb 16, 2023

I will close this as there is no indication when this EIP is going to be included in mainnet

@rakita rakita closed this Feb 16, 2023
@0xJepsen
Copy link
Contributor

0xJepsen commented Jun 9, 2023

Perhaps it makes sense to revisit this now that this EIP is to be included?

@rakita
Copy link
Member

rakita commented Jun 9, 2023

Perhaps it makes sense to revisit this now that this EIP is to be included?

Too early to start working on it now, but I am glad it got included.

@tynes
Copy link
Contributor Author

tynes commented Jun 11, 2023

When would be a good time to start on it then? Its already merged in all other clients. This would help reth be ready for a cancun testnet

@rakita
Copy link
Member

rakita commented Jun 12, 2023

When would be a good time to start on it then? Its already merged in all other clients. This would help reth be ready for a cancun testnet

Dont worry about, it will be delivered, but be mindful that I do work on other things

@0xJepsen
Copy link
Contributor

I'd like to help work on this if possible when the time is right

@snreynolds
Copy link

snreynolds commented Jul 6, 2023

This would be really great to get in so ppl can start to play around with it along with a custom solc binary. Is there any updates? Happy to help where I can also!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants