Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Overflow while calculating the remaining gas in GasInspector #287

Merged
merged 1 commit into from
Dec 7, 2022
Merged

bug: Overflow while calculating the remaining gas in GasInspector #287

merged 1 commit into from
Dec 7, 2022

Conversation

rakita
Copy link
Member

@rakita rakita commented Dec 7, 2022

reduced_gas_block was not reset.

@rakita rakita force-pushed the rakita/big_gas_inspector_underflow branch from 393925b to 100f60f Compare December 7, 2022 17:20
@rakita rakita force-pushed the rakita/big_gas_inspector_underflow branch from 8efae11 to 8afc9c5 Compare December 7, 2022 17:44
@rakita
Copy link
Member Author

rakita commented Dec 7, 2022 •
edited
Loading

tests fails bcs of --all-features turn no_gas features that stop counting gas and fails new test. tests locally

@rakita rakita merged commit 54e0333 into main Dec 7, 2022
@rakita rakita deleted the rakita/big_gas_inspector_underflow branch December 24, 2022 18:58
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rakita