feat(StateBuilder): switch builder option from without_bundle to with_bundle #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
changed the title
mattsse
requested changes
Sep 5, 2023
Comment on lines
18
to
25
| /// This will initialize cache to this state. | ||
| pub with_cache_prestate: Option<CacheState>, | ||
| /// Do we want to create reverts and update bundle state. | ||
| /// Default is true. | ||
| pub without_bundle_update: bool, | ||
| /// Default is false. | ||
| pub with_bundle_update: bool, | ||
| /// Do we want to merge transitions in background. | ||
| /// This will allows evm to continue executing. | ||
| /// Default is false. |
There was a problem hiding this comment.
Should all of these be private(pub crate) instead?
I don't think they should be mut accessible from the outside
| pub fn without_bundle_update(self) -> Self { | ||
| /// This is needed option if we want to create reverts | ||
| /// and getting output of changed states. | ||
| pub fn witho_bundle_update(self) -> Self { |
There was a problem hiding this comment.
Suggested change
| pub fn witho_bundle_update(self) -> Self { | |
| pub fn with_bundle_update(self) -> Self { |
DaniPopes
pushed a commit
to DaniPopes/revm
that referenced
this pull request
Sep 6, 2023
…_bundle (bluealloy#688) * feat(StateBuilder): make builder option become * make private field, nit rename * fix tests
mikelodder7
pushed a commit
to LIT-Protocol/revm
that referenced
this pull request
Sep 12, 2023
…_bundle (bluealloy#688) * feat(StateBuilder): make builder option become * make private field, nit rename * fix tests
Evalir
pushed a commit
to Evalir/revm
that referenced
this pull request
Sep 14, 2023
…_bundle (bluealloy#688) * feat(StateBuilder): make builder option become * make private field, nit rename * fix tests
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general output state and creating of revert is better to be something to be enabled, and not disabled.