Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various inspector fixes #69

Merged
merged 9 commits into from
Mar 7, 2022
Merged

fix: various inspector fixes #69

merged 9 commits into from
Mar 7, 2022

Conversation

onbjerg
Copy link
Collaborator

@onbjerg onbjerg commented Mar 2, 2022 •
edited
Loading

  • Removes the unused initialize function
  • Allows call_end to alter the result of the execution (e.g. for Foundry's expectRevert)
  • Calls inspectors before and after every call/creation (currently this is only done on sub-calls)
  • Fixes the lint check in CI and runs cargo fmt (last two commits which bloated the diff)
  • Updates some docs

@onbjerg onbjerg mentioned this pull request Mar 4, 2022
Merged
5 tasks
rakita
rakita reviewed Mar 7, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
rakita
rakita approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 0f6c09f into bluealloy:main Mar 7, 2022
@onbjerg onbjerg deleted the onbjerg/inspector-misc branch March 7, 2022 15:33
@onbjerg onbjerg restored the onbjerg/inspector-misc branch March 10, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onbjerg @rakita