chore: error type for block header #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Sep 20, 2023
| } | ||
| } | ||
|
|
||
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] |
There was a problem hiding this comment.
Suggested change
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] | |
| /// Errors related to misconfiguration of the `BlockEnv` | |
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] |
There was a problem hiding this comment.
resolved in 498d24c
|
@hack3r-0m can you resolve the conflict, so that we can merge it? |
|
(failing CI fixed by #735) |
|
rebased it over main |
|
@hack3r-0m missing include. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #685
I have used enum name as header since env names such as
BlockEnv,CfgEnv&Envare already used as type, let me know if prefer EnvError over this and I can quickly make that change.