Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(precompile): use Aurora modexp lib. #769

Merged
merged 7 commits into from
Oct 12, 2023
Merged

feat(precompile): use Aurora modexp lib. #769

merged 7 commits into from
Oct 12, 2023

Conversation

rakita
Copy link
Member

@rakita rakita commented Oct 5, 2023

Refactor modexp input parsing and use aurora modexp lib.

Blocked on aurora-is-near/aurora-engine#844

@rakita
Copy link
Member Author

rakita commented Oct 5, 2023 •
edited
Loading

@DaniPopes can you review this one when you have time?

Rjected
Rjected approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the slicing and padding can be a bit confusing but the implementation seems as simple as it can be

crates/precompile/src/utilities.rs Outdated Show resolved Hide resolved
crates/precompile/src/utilities.rs Outdated Show resolved Hide resolved
DaniPopes
DaniPopes approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry did not see this. LGTM

rakita and others added 2 commits October 12, 2023 08:49
@rakita @Rjected
Update crates/precompile/src/utilities.rs
a9b5439 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@rakita @Rjected
Update crates/precompile/src/utilities.rs
435b336 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@rakita rakita merged commit d320ff8 into main Oct 12, 2023
@rakita rakita deleted the modexp branch October 12, 2023 07:17
@clabby clabby mentioned this pull request Oct 15, 2023
Closed
3 tasks
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakita @Rjected @DaniPopes