Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix rustdoc warnings #859

Merged
merged 2 commits into from
Nov 12, 2023
Merged

chore: Fix rustdoc warnings #859

merged 2 commits into from
Nov 12, 2023

Conversation

NianSol
Copy link
Contributor

@NianSol NianSol commented Nov 12, 2023

Solved rust doc warnings since the issue was open since september.
One part I was uncertain was
/// Takes blob_excess_gas saves it inside env
/// and calculates blob_fee with [BlobGasAndFee].

Because there's no mention of BlobGasAndFee in the code. I assumed it to be BlobExcessGasAndPrice that is what is used in the code below it

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rakita rakita merged commit 0f25906 into bluealloy:main Nov 12, 2023
6 of 7 checks passed
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants