Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: relax state generic #881

Merged
merged 1 commit into from
Nov 24, 2023
Merged

chore: relax state generic #881

merged 1 commit into from
Nov 24, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 24, 2023

relax generic; remove trait bound

not required for struct def, as only the impl requires Database

@DaniPopes
Copy link
Collaborator

Don't know why Cargo.lock didn't get updated in #880

rakita
rakita approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very interesting. It could potentially allow DB to be DatabaseRef so both of them can be used

@rakita rakita merged commit 7a37d8d into bluealloy:main Nov 24, 2023
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @DaniPopes @rakita