Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementation of translate component #47

Merged
merged 16 commits into from
May 28, 2023

Conversation

blueaxis
Copy link
Owner

  1. Fix memory leak. The dialog is not being deleted properly when closed, so it is creating a new window every time a translation dialog is opened.
  2. Integrate the dialog in WorkspaceView. This should fix the problem above but I have no idea how it will be integrated in global captures.
  3. Change the parent of the component. Instead of having it opened in OCRView, we can use signals and slots to pass states to the parent component
  4. Improve threading. Right now, there is noticeable lag whenever a translation window is opened.

@blueaxis blueaxis force-pushed the feature/translation-component branch from 85e4e5c to 8d33d12 Compare May 27, 2023 15:17
@blueaxis blueaxis merged commit 14c2a2d into main May 28, 2023
@blueaxis blueaxis deleted the feature/translation-component branch May 28, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants