Skip to content

Commit

Permalink
[SearchResumption] Change search resumption module header to 2 lines.
Browse files Browse the repository at this point in the history
In this CL, the following changes are made:
1. Change text of the header from one line to two lines.
2. Add two strings for each line.
3. Update the text styles.
Screenshot:
https://drive.google.com/file/d/1r_P5fxoswjp1Ni4Ex4xv9-fiD106_tbi/view?usp=sharing

Bug: 1347074,1347177
Change-Id: I8c4774dd0ed349730c4d998f8987e9d6ae59a04e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785384
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1027913}
  • Loading branch information
Xi Han authored and Chromium LUCI CQ committed Jul 25, 2022
1 parent aa665a0 commit 978c032
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,32 @@
android:paddingEnd="@dimen/search_resumption_module_header_padding_start"
android:contentDescription="@string/search_resumption_module_title">

<TextView
<LinearLayout
android:id="@+id/header_text"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:singleLine="true"
android:text="@string/search_resumption_module_title"
android:textAlignment="viewStart"
android:layout_toStartOf="@+id/header_option"
android:orientation="vertical"
android:layout_alignParentStart="true"
android:textAppearance="@style/TextAppearance.TextMediumThick.Secondary"/>
android:layout_toStartOf="@+id/header_option">

<TextView
android:id="@+id/header_title_text"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:singleLine="true"
android:text="@string/search_resumption_module_title_short"
android:textAlignment="viewStart"
android:textAppearance="@style/TextAppearance.TextAccentMediumThick.Secondary"/>

<TextView
android:id="@+id/header_sub_title_text"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:singleLine="true"
android:text="@string/search_resumption_module_subtitle"
android:textAlignment="viewStart"
android:textAppearance="@style/TextAppearance.TextSmall.Secondary"/>
</LinearLayout>

<ImageView
android:id="@+id/header_option"
Expand Down
6 changes: 6 additions & 0 deletions components/browser_ui/strings/android/browser_ui_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -946,6 +946,12 @@
<message name="IDS_SEARCH_RESUMPTION_MODULE_TITLE" desc="Title of the search resumption module on NTP or Start surface.">
Suggested searches based on your last tab
</message>
<message name="IDS_SEARCH_RESUMPTION_MODULE_TITLE_SHORT" desc="Title of the search resumption module on NTP or Start surface (short version).">
Suggested searches
</message>
<message name="IDS_SEARCH_RESUMPTION_MODULE_SUBTITLE" desc="Subtitle of the search resumption module on NTP or Start surface.">
Based on your last tab
</message>
</messages>
</release>
</grit>
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0d7c695cfeb55049dda42a15f3f0e3da5c6edc56
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0d7c695cfeb55049dda42a15f3f0e3da5c6edc56

0 comments on commit 978c032

Please sign in to comment.