Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary Crashes on Launch since....962217 #45

Closed
pjpreilly opened this issue Jan 24, 2022 · 4 comments
Closed

Canary Crashes on Launch since....962217 #45

pjpreilly opened this issue Jan 24, 2022 · 4 comments

Comments

@pjpreilly
Copy link

pjpreilly commented Jan 24, 2022 •
edited
Loading

Path: /Applications/Chromium.app/Contents/MacOS/_Chromium
Identifier: _Chromium
Version: ??? (???)
Code Type: X86-64 (Native)
Parent Process: sh [7839]

Date/Time: 2022-01-24 09:10:38.161 -0500
OS Version: Mac OS X 10.7.5 (11G63)
Report Version: 9

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000

Application Specific Information:
abort() called
objc[7858]: garbage collection is OFF

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff8e3ef82a __kill + 10
1 libsystem_c.dylib 0x00007fff82ca0a9c abort + 177
2 _Chromium 0x000000010a71459c (anonymous namespace)::FatalError(char const*, ...) + 252
3 _Chromium 0x000000010a71448a main + 282
4 _Chromium 0x000000010a714364 start + 52

Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x0000000000000000 rbx: 0x00007fff6a311ad0 rcx: 0x00007fff6a311ab8 rdx: 0x0000000000000000
rdi: 0x0000000000001eb2 rsi: 0x0000000000000006 rbp: 0x00007fff6a311ae0 rsp: 0x00007fff6a311ab8
r8: 0x000000010a731a00 r9: 0x0000000000000000 r10: 0x00007fff8e3f0e62 r11: 0x0000000000000206
r12: 0x000000010a809ef0 r13: 0x00007f85b3807400 r14: 0x000000010a714c8a r15: 0x00007fff6a311af0
rip: 0x00007fff8e3ef82a rfl: 0x0000000000000206 cr2: 0x000000010a748000
Logical CPU: 0
@pjpreilly
Copy link
Author

on macbook 4,1 Lion....

@pjpreilly pjpreilly changed the title Canary Crashes on Canary Crashes on Launch since....962217 Jan 24, 2022
@Wowfunhappy
Copy link

Wowfunhappy commented Jan 24, 2022 •
edited
Loading

Can confirm on 10.9.5: build 962217 crashes, build 961769 does not. However, on Mavericks I'm getting a different and potentially more useful log:

dlopen /Applications/Chromium.app/Contents/MacOS/../Frameworks/Chromium Framework.framework/Versions/100.0.4845.0/Chromium Framework: dlopen(/Applications/Chromium.app/Contents/MacOS/../Frameworks/Chromium Framework.framework/Versions/100.0.4845.0/Chromium Framework, 261): Symbol not found: _NSUserActivityTypeBrowsingWeb
  Referenced from: /Applications/Chromium.app/Contents/MacOS/../Frameworks/Chromium Framework.framework/Versions/100.0.4845.0/Chromium Framework
  Expected in: /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
 in /Applications/Chromium.app/Contents/MacOS/../Frameworks/Chromium Framework.framework/Versions/100.0.4845.0/Chromium Framework.Abort trap: 6

Looks like it may be e68a0f3? (Specifically line 140.)

@blueboxd
Copy link
Owner

Thanks! 🙇
Already fixed (c596a91) in recent releases.

blueboxd pushed a commit that referenced this issue Feb 3, 2022
M98 Revert "[lacros] enables fractional scale support."
a67e1cf 
This reverts commit c1c9c0c.

Reason for revert: causing popup menu visual problem.

Original change's description:
> [lacros] enables fractional scale support.
>
> Bug: 1246388
> Change-Id: I07381c8c0f4320e7ea97677f8432918c4c83ff3f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3285833
> Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
> Auto-Submit: Jun Liu <yjliu@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#942259}

Bug: 1272127
Change-Id: Ie102b294015cc01472a207cea4ddcabd57a9e465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334102
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#951221}

(cherry picked from commit f90621e)

Change-Id: If21858d5b91b0fe00fb3698bc9adc76d1436dce9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339711
Commit-Queue: Jun Liu <yjliu@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Owners-Override: Srinivas Sista <srinivassista@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4758@{#45}
Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
@pjpreilly
Copy link
Author

happening again.....

Process: Chromium [958]
Path: /Applications/Chromium.app/Contents/MacOS/Chromium
Identifier: org.chromium.Chromium
Version: 100.0.4892.0 (4892.0)
Code Type: X86-64 (Native)
Parent Process: launchd [119]

Date/Time: 2022-02-16 06:53:46.090 -0500
OS Version: Mac OS X 10.7.5 (11G63)
Report Version: 9

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000

Application Specific Information:
abort() called
objc[958]: garbage collection is OFF

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff90a3182a __kill + 10
1 libsystem_c.dylib 0x00007fff852e2a9c abort + 177
2 org.chromium.Chromium 0x0000000104f6237c (anonymous namespace)::FatalError(char const*, ...) + 252
3 org.chromium.Chromium 0x0000000104f62267 main + 279
4 org.chromium.Chromium 0x0000000104f62144 start + 52

Thread 0 crashed with X86 Thread State (64-bit):
rax: 0x0000000000000000 rbx: 0x00007fff64b5fb70 rcx: 0x00007fff64b5fb58 rdx: 0x0000000000000000
rdi: 0x00000000000003be rsi: 0x0000000000000006 rbp: 0x00007fff64b5fb80 rsp: 0x00007fff64b5fb58
r8: 0x0000000104fd9a00 r9: 0x0000000000000000 r10: 0x00007fff90a32e62 r11: 0x0000000000000206
r12: 0x0000000105009ef0 r13: 0x00007f8a09807400 r14: 0x0000000104f84302 r15: 0x00007fff64b5fb90
rip: 0x00007fff90a3182a rfl: 0x0000000000000206 cr2: 0x0000000104ff0000
Logical CPU: 0

@pjpreilly pjpreilly mentioned this issue Feb 16, 2022
Closed
blueboxd pushed a commit that referenced this issue Jun 22, 2022
Roll ChromeOS Bigcore AFDO profile from 103-5005.20-1651490602-benchm…
777203b 
…ark-103.0.5045.0-r1 to 103-5045.0-1652695838-benchmark-103.0.5060.8-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ic8ba4a941a52a742235d8dbdc78468419645160e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651947
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{#45}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
[ClockSkew] Add metric for range of minutes added to avoid expiry
b1d410c 
To gather more information on what range of minutes added to the expiration time managed to keep a cookie from expiring immediately, another custom counts histogram was added.

Additionally, there was a significant amount of cookies in the 12 hours bucket, so to further investigate this, I added metrics that also record up to 24 hours.

(cherry picked from commit f13c5d7)

Bug: 1345942
Change-Id: I9f2d229e8c78da9cd8fef6d9b7a7dc6c71e612fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777857
Commit-Queue: Kyra Seevers <kyraseevers@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1027916}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3784264
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Auto-Submit: Kyra Seevers <kyraseevers@chromium.org>
Cr-Commit-Position: refs/branch-heads/5195@{#45}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
[Merge to M106] ios: Fix crash when adding bookmark from incognito.
36e7eee 
The on-the-record BookmarkIneractionController is always used when
adding or editing bookmarks. A refactor in crrev.com/c/3755541 changed
the logic to use the on-the-record WebState (which can be null) when
determining the title and URL for a bookmark.

Instead, pass a BookmarkAddCommand with the correct WebState.

(cherry picked from commit f69798c)

Fixed: 1353114
Change-Id: Iadf8de4445ad24e059d1889f5ac503d2887f81ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846908
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1038084}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846564
Owners-Override: Krishna Govind <govind@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Krishna Govind <govind@chromium.org>
Auto-Submit: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{#45}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
@alisonmaher
[GridFragmentation] OOF static position when CB is outside multicol
4c157d9 
The static position of OOFs in a fragmented grid container were
determined within the last fragment. If the OOF's CB lives outside the
associated multicol, then that static position would be relative to
the last parent fragment and would become negative.

Similar to CL:3927797, attempt to determine the static position in
the fragment it belongs. Note that this may end up being incorrect
for center aligned items, or items with a grid-area that does not
start in the first or last fragment.

(cherry picked from commit bf52bf7)

Bug: 1367912
Change-Id: I61bf29ccf97d2bb293ba7916f327883f43e53214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3949467
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Original-Commit-Position: refs/heads/main@{#1059352}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961637
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Alison Maher <almaher@microsoft.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5359@{#45}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
@shhnjk
[CP] Add more histograms for Blob URL in Active Document
2b602a8 
Measure the usage of Blob URL in active document. In particular,
this CL measures:

1. The Blob URL was loaded in main frame or iframe.
2. The Blob URL was opaque origin.

This would allow us to see if there is a way to narrow down a solution
we aimed for in crrev.com/c/3911771 to specific navigation types.

Bug: 1400338


(cherry picked from commit 4a8f95e)

Change-Id: Ia3c42c9ad300b4241f0bf79ebe3831da3b5e51a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4098364
Auto-Submit: Jun Kokatsu <jkokatsu@google.com>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1084523}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4116017
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#45}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
@beaufortfrancois
PiP 2.0: Reuse player when window is opened.
60c6999 
This CL fixes a bug introduced recently[1] so that the HTML media player
is now reused if the Document Picture-in-Picture API is enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4190826

(cherry picked from commit ff8497c)

Change-Id: I24b7d0080cf9ee9e054c2a20a2f6d98911898b06
Bug: 1411201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4202152
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Original-Commit-Position: refs/heads/main@{#1098495}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208087
Cr-Commit-Position: refs/branch-heads/5563@{#45}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
Persist churn observation data across restarts and powerwash
d3dca54 
Handle recovery of observation churn observation period status.
Integrate local state and preserved files as layers of persistence of
observation use case data.

Since the observation use case reports strictly after the cohort use
case, we can add persistence of the observation last pinged month based
on the latest cohort active status value. The booleans for the previous
3 months of whether a ping was sent can also be recovered based on the
last ping month date. These 3 booleans are relative to the date the
cohort last pinged.

Adding this persistence helps avoid duplicate observation imports on
restarts and powerwashes. The caveat here is that all cohort and
observation data is lost after recovery. In the future, we plan to add
check membership requests after recovery case to persist this data
further.

BUG=chromium:1386189

(cherry picked from commit 07ca7c5)

Change-Id: I7da620dae5861a2cf3238ee4e684ab2631f7600b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4283429
Commit-Queue: Hirthanan Subenderan <hirthanan@google.com>
Reviewed-by: Jong Ahn <jongahn@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1109422}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296755
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#45}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
@ckitagawa-work
[M113][Tab Management] Fix phantom tab on longpress
5ba249d 
If a longpress on a tab occurs for the purpose of drag & drop with no
drag event occurring then the downstream click handlers resolve the
input as a click rather than a longpress.

This previously caused significant problems when implementing the
longpress handler for TabSelectionEditorV2. However, it turns out that
this behavior can sometimes have negative outcomes even without the
longpress handler being installed.

Specifically, longpressing with no drag can result in either of the
following handler running:
* Selection - Tab is selected - no real issue, but usually a longpress
  cancels a click action.
* Close - Tab is closed & there is a race condition where the
  animation for the longpress and close race resulting in a phantom
  tab stuck in the UI.

The solution is to move the up motion event blocking that was added
for the longpress handler to always apply thus avoiding this bug ever
occurring. See inline comments for detailed explanation.

Unrelated flaky tests failing.

(cherry picked from commit 67f1fe9)

Validate-Test-Flakiness: skip
Bug: 1425336
Change-Id: I289d6400cefef8fb5edbe5a4728942e27bf23a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4367579
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Brandon Fong <bjfong@google.com>
Commit-Queue: Brandon Fong <bjfong@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1121907}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375338
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#45}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
Revert "[Start] Enable two StartSurfaceBackButtonTest#testSwipeBack* …
6d094dc 
…tests"

This reverts commit 1dbd803.

Reason for revert: The tests are still flaky. 

Original change's description:
> [Start] Enable two StartSurfaceBackButtonTest#testSwipeBack* tests
>
> After adding the statement "AsyncInitializationActivity.interceptMoveTaskToBackForTesting();". We have run the tests StartSurfaceBackButtonTest#testSwipeBackOnStartSurfaceHomePage__* and StartSurfaceBackButtonTest#testSwipeBackOnStartSurfaceHomePage_BackGestureRefactor__* with android-12-x64-rel, and android-nougat-x86-rel. Since we didn't find out any error with these tests, we enabled it.
>
> Bug: 1246457, 1371614, 1371613, 1371612, 1434978
> Change-Id: I6c09f454fc64e6fbd0cb106c071be7382cb88288
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4461529
> Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
> Reviewed-by: Xi Han <hanxi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1134849}

(cherry picked from commit d514aa4)

Bug: 1246457, 1371614, 1371613, 1371612, 1434978, 1440651
Change-Id: Idefd59cef00138115674a28ebe2a37c3e4acbfcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481146
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136531}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4487871
Owners-Override: Friedrich Horschig <fhorschig@chromium.org>
Auto-Submit: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/branch-heads/5735@{#45}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wowfunhappy @pjpreilly @blueboxd