981631 build crashes on file download #53
Comments
|
Can you try the latest stable build and see if it still crashes? If it works there, we'll need to test Chrome Canary on a newer OS to see if the problem is Chromium-legacy-specific or not. |
|
@Wowfunhappy it doesn't happen on the stable version, but I can't use it because the profile gets corrupted due downgrade. |
|
Okay, I've confirmed this issue isn't present in Chrome Canary, so it is a Chromium Legacy issue. I've also bisected the crash—build 979273 is the first problematic build, whereas 278255 does not exhibit the problem. Tested in Lion; the issue does not exist on Mavericks. (I don't think downgrading should completely corrupt your profile? I usually just loose cookies.) |
|
This appears to have been fixed as of build 986492! If it's fixed for you too @aeiouaeiouaeiouaeiouaeiouaeiou, I recommend closing this issue. |
|
LGTM, now I need to understand the reason of random kernel panics. On some sites with heavy javascript browser freezes and reboots the computer, but no any logs are left in the system console. |
|
Re: kernel panics, definitely a look at #44, I actually feel like we're pretty close to getting to the bottom of it! |
blueboxd
pushed a commit
that referenced
this issue
Jun 22, 2022
(cherry picked from commit 40491ae) Bug: b/205961819 Change-Id: I7e9f45fa6ab9b61644281acb79acf0e52be8fa73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3615574 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1003846} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651361 Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#53} Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd
pushed a commit
that referenced
this issue
Aug 31, 2022
This CL fix the issue where default controls in Picture-in-picture window is controlling wrong media when pip'ed media isn't active. This is caused by default controls in pip window are meant for active media session. The CL fix the issue by adding custom controls (play/pause, previous track, next track) to Picture-in-picture params to override the default controls. Bug: 1345255 (cherry picked from commit 0dbc538) Change-Id: I92d87513d12c919eb0a4ebc7d37d4de6fec10766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3773420 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1027363} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3785119 Owners-Override: Krishna Govind <govind@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Krishna Govind <govind@chromium.org> Auto-Submit: Jazz Xu <jazzhsu@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/5195@{#53} Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd
pushed a commit
that referenced
this issue
Sep 29, 2022
(cherry picked from commit 53112b9) Change-Id: I4ade6932969233cd03a79757445b3ae89bc80d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845178 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1037724} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3851063 Auto-Submit: Peter Kasting <pkasting@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249@{#53} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd
pushed a commit
that referenced
this issue
Nov 30, 2022
When you try to download a file with a given path and this path does not exist, it throw an error. This CL fix this by checking if the folder exist or create it otherwise when user tap on the share button, before starting the download. (cherry picked from commit 0ee2fb6) Fixed: 1371047, 1373233, 1373230 Change-Id: Ibee5797f290b82e78d8ba72d3aa4ba977d36a685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3948509 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Aliona Dangla <alionadangla@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1059189} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3959752 Auto-Submit: Aliona Dangla <alionadangla@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/5359@{#53} Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd
pushed a commit
that referenced
this issue
Feb 8, 2023
This CL moves the Remote Playback from GMC flag to media_switches.h so that it can be used by media_session_notification_item.cc to hide "showing Remote Playback info in local media session notifications" behind the flag. (cherry picked from commit 7550d6b) Bug: 1392875 Change-Id: Ia74b183decb9e972b5dd033cca338c38b5d72bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4104964 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1084426} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119162 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Auto-Submit: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/branch-heads/5481@{#53} Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd
pushed a commit
that referenced
this issue
Mar 7, 2023
…111.0.5563.4-r1 to 111-5550.0-1675078804-benchmark-111.0.5563.7-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-arm-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie5e45aeeb3462e8715e9cac124d03d62d3f5b482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209448 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5563@{#53} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd
pushed a commit
that referenced
this issue
Apr 14, 2023
…merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-beta Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic696232c56beda643dfdcfed86c71be47dac9453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296360 Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5615@{#53} Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd
pushed a commit
that referenced
this issue
May 9, 2023
Merge CL to m113. crrev.com/c/4273874 added a `Omnibox.OmniboxEditModelOpenMatchTime` histogram, but the code was logging to `Omnibox.OpenMatchTime`, making the data unavailable in UMA. This CL fixes the typo. This CL also updates the buckets of `Omnibox.SuggestionUsed.Search.InputToNavigationStart2` & `Omnibox.SuggestionUsed.URL.InputToNavigationStart2`. Previously, they covered [10ms, 10minutes]. But 30% of events fell in the underflow bucket (55% in an experiment), and 99.999% of events fell in the <14s bucket [1]. This CL updates the histograms to cover [1ms, 1minute] and renames them (`...InputToNavigationStart` -> `...InputToNavigationStart2`). [1] https://uma.googleplex.com/p/chrome/timeline_v2?sid=3850b51de4e1b9122d37fbb6a169b1a6 (cherry picked from commit bc5575d) Bug: 1418490 Change-Id: Icbad05e77f1122ae15f4b54e2610b0ece9feb568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370582 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Auto-Submit: manuk hovanesian <manukh@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1121977} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375321 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5672@{#53} Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd
pushed a commit
that referenced
this issue
May 27, 2023
Change-Id: Ic72b557ea77c64864b532ac271d3d918c0464336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489404 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/5735@{#53} Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tried this link for an example, the result is in bug report:
The text was updated successfully, but these errors were encountered: