Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(osx) how enable print preview like on google chrome? #57

Closed
mrkapqa opened this issue Apr 4, 2022 · 4 comments
Closed

(osx) how enable print preview like on google chrome? #57

mrkapqa opened this issue Apr 4, 2022 · 4 comments

Comments

@mrkapqa
Copy link

mrkapqa commented Apr 4, 2022

hello ,

i am contacting you
in hope to being able to enable the feature "print preview" on chromium legacy as on google chrome.

it seems that onmy computer the feature is not readily available;
it is, if installed google chrome,
and i found a lot of tips on how to disable print preview for google chrome, it seems a lot of people dislike feature
but since i prefer using chromium over chrome,
cannot find how to enable it;
kindly ask on how to enable this feature "permanently" on my computer

using an older mac with os x mavericks,
chromium installed via chromium-legacy-downloader
Version 100.0.4896.60 (Official Build) (x86_64)

thanks.

@Wowfunhappy
Copy link

Are you using my prefpane by any chance? #25 It’s designed to always disable the print preview.

@mrkapqa
Copy link
Author

mrkapqa commented Apr 4, 2022

yes, thanks, did not know, although was suspecting it;
but also downloads from releases pages (older ones) somehow dont achieve the "desired" result .. on this computer with chromium seems no print preview enabled.
the chromium downloader also downloads google chrome, so i got confused by thinking it is enabled, when in fact it was enabled on the google chrome app only.

@Wowfunhappy
Copy link

Hey, let's close this issue and move the conversation here: #25 (comment)

@mrkapqa
Copy link
Author

mrkapqa commented Apr 4, 2022

thanks, issue solved.

@mrkapqa mrkapqa closed this as completed Apr 4, 2022
blueboxd pushed a commit that referenced this issue Jun 22, 2022
This fixes an issue where Poly speakers are not shown in the pairing UI.

(cherry picked from commit 419ea9a)

Bug: b/228118615
Test: device_unittests, plus on-device verification with Poly device
Change-Id: Ic2ec9ad62ab57648d7dcb59caa5eeae767071565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3612430
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Gordon Seto <gordonseto@google.com>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1002931}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652543
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{#57}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
Change-Id: I7c5559f0b82ab6d0018a089dc52a781b5a288a47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3784291
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5195@{#57}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
Change-Id: I780cd24731b1445b8d0da839102f304a7a9d3f34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3853201
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#57}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
This CL closes any JS dialogs left behind by the previous
page when a new navigation starts, since these are no
longer relevant to the user.

(cherry picked from commit 2d0d1fc)

Bug: 1373025
Change-Id: I8bec157bf2cd83a9a15f9b83ecad2e89820e7b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3954143
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1059942}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963294
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/branch-heads/5359@{#57}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
This CL addresses leftover work from [1]. Specifically:

- In v4l2_video_decoder_delegate_av1.cc::SetupFrameParams(), the block
  that fills out v4l2_frame_params.order_hints needs to be guarded by
  !libgav1::IsIntraFrame(frame_header->frame_type) instead of
  frame_header.frame_type != libgav1::kFrameKey. The reasons are that a)
  the OrderHints variable in the spec is only filled out for non-intra
  frames (not just for non-key frames); and b) if the frame is
  intra-only or key, frame_header.reference_frame_index may be
  uninitialized [2] so it's unsafe to use it.

- The static_assert that checks the size of the
  v4l2_frame_params.order_hints array is moved closer to the loop and is
  made to compare against libgav1::kNumInterReferenceFrameTypes + 1
  instead of libgav1::kNumReferenceFrameTypes to make it clearer that
  the static_assert is there to document/check that the indices accessed
  by the subsequent loop are safe to access (the loop uses
  libgav1::kNumInterReferenceFrameTypes).

We also make corresponding changes in the standalone
v4l2_stateless_decoder.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3942434/comment/70e35d4c_e7698200/
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/libgav1/src/src/utils/types.h;l=497-499;drc=c55bc9dd7f26ec3b1de0673caa1510bfa3094b3f

(cherry picked from commit d8e4ec6)

Bug: b:248602457
Test: tast run ${IP} video.*av1* on a cherry device
Change-Id: I41b56576f2dfe2c9e7dcf0affa9ae2dc43e544e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112326
Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Steve Cho <stevecho@chromium.org>
Reviewed-by: Steve Cho <stevecho@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1084090}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4120740
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#57}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
This is a reland of commit 20fca53

It adds default values for daily_refresh_enabled and collection_id to uploaded images since we now expect these for all CustomBackground structs. Also fixes the setting up of custom background in test (the main culprit).

Original change's description:
> [ntp] Store collection ids for theme background images
>
> This CL concerns the NTP handler. A follow up CL will bring the changes here to the Customize Chrome handler.
>
> Prior to this CL collection ids were only stored in user prefs ('prefs::kNtpCustomBackgroundDict') if daily refresh was turned on.
>
> Now, collection IDs will be stored anytime a theme is set.
>
> This CL obsoletes a test in ntp_custom_background_service_unittest.cc that makes sure collection ID takes priority over background URL. Before and after this CL, there are no calls to SetCustomBackground for daily refresh in the codebase where both URL and collection id are set (https://source.chromium.org/search?q=-file:out%20SetCustomBackgroundInfo%20-file:test).
>
> The changes in the CL will allow us to create a metric that stores the collection ID used by the user on NTP load.
>
> Change-Id: Ief491945ec77b6b06f56dc4ff42bad2774eb9ca4
> Bug: 1384258
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4183244
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Commit-Queue: Paul Adedeji <pauladedeji@google.com>
> Reviewed-by: Riley Tatum <rtatum@google.com>
> Cr-Commit-Position: refs/heads/main@{#1097166}

(cherry picked from commit 5c7d381)

Bug: 1384258
Change-Id: I101f478becf2eb412cca51c6fc919cf1eb7fc854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198399
Reviewed-by: Riley Tatum <rtatum@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1097786}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4205669
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Riley Tatum <rtatum@google.com>
Cr-Commit-Position: refs/branch-heads/5563@{#57}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
https://chromium.googlesource.com/v8/v8.git/+log/9c6d767b3121..c3e99752ac5a

2023-02-28 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.2.214.5
2023-02-28 clemensb@chromium.org Merged: [wasm] Fix decoding of prefixed opcodes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-release-0
Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in v8 11.2: https://bugs.chromium.org/p/v8/issues/entry
To file a bug in Chromium m112: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1418706
Tbr: v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: Ideac0b54d9ea89e825445efbebfbc46b27fa0c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296830
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#57}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
-Include feature flag

(cherry picked from commit add35f1)

Bug: 1425232
Change-Id: I50833ccfd0be034055b18205c9334e81bbca734d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347577
Commit-Queue: Zach Katz <katzz@google.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Kevin Grosu <kgrosu@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1121881}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375055
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#57}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
(cherry picked from commit 451836e)

Bug: 1440128
Change-Id: I2e2a5822b6bae6a642c62dae8e1de49be9f38609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4477593
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136566}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489790
Cr-Commit-Position: refs/branch-heads/5735@{#57}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants