Skip to content

Commit

Permalink
Tweaks to support building with OpenJDK 21.0.2; no functional changes (
Browse files Browse the repository at this point in the history
…#147)

* Tweaks to support building with OpenJDK 21.0.2; no functional changes

* Also update github-action workflow to use Java version temurin:21

* README.md update; POM version updates to 5.2.2-SNAPSHOT
  • Loading branch information
bluedenim authored Mar 18, 2024
1 parent 9f827a2 commit 8f6d33b
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 16 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Set up JDK 11.0.10
- name: Set up JDK termurin:21
uses: actions/setup-java@v1
with:
java-version: '11.0.10'
distribution: 'temurin'
java-version: '21'
- name: Build with Maven
run: mvn -U -B package --file pom.xml
14 changes: 6 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,12 @@ The [packages in MVN Repo](https://mvnrepository.com/search?q=therealvan) should
correct Java version (see below).


| Release / tag | JSDK version |
|-----------------|------------------------------------------------------------------------------------------------|
| 2.x and earlier | [Java SDK (JDK) 8](https://www.oracle.com/java/technologies/javase/javase-jdk8-downloads.html) |
| 3.x | [Java SDK (JDK) 11](https://www.oracle.com/java/technologies/javase-jdk11-downloads.html) |

Note that using [Java SDK (JDK) 14](https://docs.oracle.com/en/java/javase/14/) to build the projects locally will
have errors. You can try basing your work on [PR 59](https://github.com/bluedenim/log4j-s3-search/pull/59) if you
really need to build with the newer JDKs.
| Release / tag | JSDK version |
|-------------------|------------------------------------------------------------------------------------------------|
| 2.x and earlier | [Java SDK (JDK) 8](https://www.oracle.com/java/technologies/javase/javase-jdk8-downloads.html) |
| 5.2.1 and earlier | [Java SDK (JDK) 11](https://www.oracle.com/java/technologies/javase-jdk11-downloads.html) |
| 5.2.2+ | [OpenJDK 21](https://openjdk.org/projects/jdk/21/) |


## Packages
The project is broken up into several packages:
Expand Down
16 changes: 14 additions & 2 deletions appender-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>appender-core</artifactId>
<version>5.1.1-SNAPSHOT</version>
<version>5.2.2-SNAPSHOT</version>
<name>appender-core</name>
<description>Core functionality to send content to various channels, used by appender-log4j2</description>
<url>https://github.com/bluedenim/log4j-s3-search</url>
<parent>
<groupId>com.therealvan</groupId>
<artifactId>log4j-s3-search</artifactId>
<version>5.1.0</version>
<version>5.2.2-SNAPSHOT</version>
</parent>

<properties>
Expand Down Expand Up @@ -156,6 +156,18 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>
--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.time=ALL-UNNAMED
--add-opens java.base/java.time.format=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED
</argLine>
</configuration>
</plugin>
</plugins>
</build>
<distributionManagement>
Expand Down
18 changes: 15 additions & 3 deletions appender-log4j2/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>appender-log4j2</artifactId>
<version>5.1.1-SNAPSHOT</version>
<version>5.2.2-SNAPSHOT</version>
<name>appender-log4j2</name>
<description>Log4j 2.x appender to capture and send log events to remote storage (AWS S3, Azure Blob Storage, Google Cloud Storage) and search (Solr, Elasticsearch)</description>
<url>https://github.com/bluedenim/log4j-s3-search</url>
Expand All @@ -11,7 +11,7 @@
<parent>
<groupId>com.therealvan</groupId>
<artifactId>log4j-s3-search</artifactId>
<version>5.1.0</version>
<version>5.2.2-SNAPSHOT</version>
</parent>

<properties>
Expand All @@ -22,7 +22,7 @@
<dependency>
<groupId>com.therealvan</groupId>
<artifactId>appender-core</artifactId>
<version>5.1.1-SNAPSHOT</version>
<version>5.2.2-SNAPSHOT</version>
<exclusions>
<exclusion>
<groupId>com.amazonaws</groupId>
Expand Down Expand Up @@ -168,6 +168,18 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>
--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.time=ALL-UNNAMED
--add-opens java.base/java.time.format=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED
</argLine>
</configuration>
</plugin>
</plugins>
</build>
<distributionManagement>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<groupId>com.therealvan</groupId>
<artifactId>log4j-s3-search</artifactId>
<packaging>pom</packaging>
<version>5.1.1-SNAPSHOT</version>
<version>5.2.2-SNAPSHOT</version>
<name>log4j-s3-search</name>
<description>Parent POM for the log4j-s3-search project and used by appender-core, appender-log4j, and appender-log4j2 projects.</description>
<url>https://github.com/bluedenim/log4j-s3-search</url>
Expand Down

0 comments on commit 8f6d33b

Please sign in to comment.