Users lookup broken

[thet]

with bda.plone.shop (and bda.plone.productshop) on Plone 4.3, the user lookup is broken. Instead of the username something like this is displayed: <object object at 0x7fd704e09580>

Example for documentByLine:

[agitator]

imho that's an issue in Plone 5 too

[rnixx]

This bug went in somewhen in p4.x, yes.

[rnixx]

This is probably a good place to start

https://github.com/bluedynamics/bda.plone.shop/blob/master/src/bda/plone/shop/user/configure.zcml

at the time the users stuff went into the shop there was heavy progress on plone.app.users, so chances are hight the something has been optimized until broken or so

[jochumdev]

I have been looking into this.

Debug

While debugging this i found that we use two different _marker in PlonePAS.tools.memberdata.MemberDataTool and Products.CMFCore.MemberDataTool.MemberData, the value we see is the _marker from PlonePAS this is a bug.

When you change the _marker to be imported from CMFCore you get an error "no such property fullname", this is because we delete that property in portal_memberdata over memberdata_properties.xml.

When you manualy readd this property over the CMI you get another error then no such property location, we also delete location from portal_memberdata, so i added that property too and it works.

The fields don't get displayed in @@personal-information.

Possible Solution

• Register our own Properties Plugin for PlonePAS so MemberDataTool.getProperty returns the computed versions of fullname and location as in UserDataSchemaAdapter.
• Additional: Fix the bug in PlonePAS.

[jochumdev]

I just found http://docs.plone.org/4/en/old-reference-manuals/pluggable_authentication_service/properties-plugins.html looks like we need to implement that, will update the comment above.

[thet]

The PlonePAS bug should be fixed first.

The customization of userdata properties was done like in https://github.com/collective/collective.examples.userdata

If we need a custom properties plugin, then ok. The implementation looks quite easy. It sounds just not very extensible - it may conflict with other addons, if they provide their own userdata property adapters. But that's maybe negligible.

So, go ahead! :)

[jochumdev]

PlonePAS pr is here

[thet]

@pcdummy PlonePAS merged. PR for bda.plone.shop up not ready yet?

[jochumdev]

Sorry, forgot to add a PR for this.

[jochumdev]

It works with Plone5 but i found a bug, the new Plugin must be last so this works and it doesn't get sorted in as the last one.

Will add a second PR soon.