No AudioPlayerState?

[ThinkDigitalSoftware]

The old package had a way to indicate if the player was playing. What's the reasoning behind removing it?

[luanpotter]

Thanks for your feedback! There was no reason behind removing it because it was not removed.

Actually, the original audioplayer package didn't have this feature. It does now, but that was just recently added. There was no built-in way to do it when the fork occurred. However, you can easily control your own state, like this Widget in the example does (and it uses a enum just like the one you want).

[ThinkDigitalSoftware]

I was thinking about adding it, but I didn't want to create yet another fork. I think it's a necessary part of the player. Especially since yours manages multiple players.

On Wed, Jul 18, 2018 at 5:41 PM Luan Nico ***@***.***> wrote: Thanks for your feedback! There was no reason behind removing it because it was not removed. Actually, the original audioplayer package didn't have this feature. It does now, but that was just recently added. There was no built-in way to do it when the fork occurred. However, you can easily control your own state, like this Widget <https://github.com/luanpotter/audioplayer/blob/master/example/lib/player_widget.dart> in the example does (and it uses a enum just like the one you want). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV-HfWBQU1Jx_HICPDVB9zQwH_3XT6KFks5uH9XKgaJpZM4VU1l2> .

-- Think Digital 323-638-9448 760-678-8833 Facebook.com/ThinkDigitalRepair

[luanpotter]

Please, contribute with a PR! I'll be glad to merge it in. :)
It can be done completely in the dart code, so it won't interfere with the native behavior.
Just add a variable to the player to hold the current state and update it in every related method call :)

[ThinkDigitalSoftware]

When I tried forking your fork, it showed me my fork of the original project, how do I submit a PR to your fork directly?

…

On Jul 19, 2018, at 1:05 PM, Luan Nico ***@***.***> wrote: Please, contribute with a PR! I'll be glad to merge it in. :) It can be done completely in the dart code, so it won't interfere with the native behavior. Just add a variable to the player to hold the current state and update it in every related method call :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV-HfYi3GvllAqrsYNh2tNQvMbiQGiVrks5uIOaDgaJpZM4VU1l2>.

[luanpotter]

Hahaha never thought of that problem!

I'm not sure, but I believe you can use the same cloned repo you already have on your machine; just add my repo as a remote (e.g., git remote add luanpotter_remote git@github.com:luanpotter/audioplayer.git), and then pull my master branch. Create a new branch from my master, make your commits, and then open the PR from that repo (it will show up, I believe, in my repo's PR page).

Always take a look at the diff of the PR to make sure you are submitting just your changes and not something else that might have come along.

Alternatively you could create a PR without a fork (though I think it'd be harder), check this out on how to do that. Basically clone my repo, create the branch directly and then you can PR from the terminal (IIRC).

[ThinkDigitalSoftware]

I’m getting this error in Dart analysis. Is this something that can be ignored? warning: The option 'enableStrictCallChecks' isn't supported by 'language'. (unsupported_option_with_legal_values at [audioplayers] analysis_options.yaml:4)

[luanpotter]

That is probably an older option that was present in the analysis_options file that is no longer required (maybe this explains it).

You could remove that line from the analysis_options file in your PR if you'd like :)

[ThinkDigitalSoftware]

Will do

…

On Jul 19, 2018, at 1:43 PM, Luan Nico ***@***.***> wrote: That is probably an older option that was present in the analysis_options file that is no longer required (maybe this <dart-lang/sdk#31509> explains it). You could remove that line from the analysis_options file in your PR if you'd like :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV-HfQ2g--ZqjO6USgwUr-VrA5KmLhjzks5uIO9YgaJpZM4VU1l2>.

[luanpotter]

Thanks, @renancaraujo , fixed due to #68.

[ThinkDigitalSoftware]

Thanks!

…

On Fri, Jan 4, 2019, 8:15 AM Luan Nico ***@***.*** wrote: Thanks, @renancaraujo <https://github.com/renancaraujo> , fixed due to #68 <#68>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV-Hfem91PXUWwiEbDX_oe9V_-e4o4GEks5u_34agaJpZM4VU1l2> .