Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use fixed version of flutter-action #1506

Merged
merged 1 commit into from
May 14, 2023
Merged

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented May 14, 2023

Description

Like in flame it is more practicable to use fixed version of flutter-action to avoid unexpected failures of the CI.

Further when flutter is releasing a new version, one should upgrade the version of flutter-action and also add the required changes to pass the tests at the same time.

This ensures that the tests in the main always stay consistent. It also makes the development faster and more independent of other packages such as flame-lint.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

flame-engine/flame#2532

@Gustl22 Gustl22 requested a review from spydon May 14, 2023 09:30
@Gustl22 Gustl22 merged commit f719091 into main May 14, 2023
@Gustl22 Gustl22 deleted the gustl22/flutter-action branch May 14, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants