Skip to content

Commit

Permalink
0.14.0 rc (#514)
Browse files Browse the repository at this point in the history
* remove pubspec

* fix validation

* update example

* bump

* changelog

Co-authored-by: renancaraujo <renan.araujo@dashdash.com>
  • Loading branch information
renancaraujo and renancaraujo authored May 24, 2022
1 parent 23063d5 commit c5fcfdc
Show file tree
Hide file tree
Showing 13 changed files with 158 additions and 665 deletions.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,5 @@ build/
!**/ios/**/default.perspectivev3
!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
.fvm/*

pubspec.lock
154 changes: 74 additions & 80 deletions CHANGELOG.md

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion example/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@ macos/
ios/
android/
web/
.fvm/
.fvm/
windows/
73 changes: 73 additions & 0 deletions example/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
analyzer:
errors:
mixin_inherits_from_not_object: ignore
linter:
rules:
- always_declare_return_types
- always_put_control_body_on_new_line
- always_require_non_null_named_parameters
- annotate_overrides
- avoid_classes_with_only_static_members
- avoid_empty_else
- avoid_field_initializers_in_const_classes
- avoid_function_literals_in_foreach_calls
- avoid_init_to_null
- avoid_null_checks_in_equality_operators
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_slow_async_io
- await_only_futures
- camel_case_types
- cancel_subscriptions
- control_flow_in_finally
- directives_ordering
- empty_catches
- empty_constructor_bodies
- empty_statements
- hash_and_equals
- implementation_imports
- iterable_contains_unrelated_type
- library_names
- library_prefixes
- list_remove_unrelated_type
- no_adjacent_strings_in_list
- no_duplicate_case_values
- non_constant_identifier_names
- overridden_fields
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_adjacent_string_concatenation
- prefer_asserts_in_initializer_lists
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_const_declarations
- prefer_const_literals_to_create_immutables
- prefer_contains
- prefer_equal_for_default_values
- prefer_final_fields
- prefer_final_locals
- prefer_foreach
- prefer_initializing_formals
- prefer_is_empty
- prefer_is_not_empty
- prefer_typing_uninitialized_variables
- recursive_getters
- slash_for_doc_comments
- sort_constructors_first
- sort_unnamed_constructors_first
- test_types_in_equals
- throw_in_finally
- type_init_formals
- unnecessary_brace_in_string_interps
- unnecessary_getters_setters
- unnecessary_null_aware_assignments
- unnecessary_null_in_if_null_operators
- unnecessary_overrides
- unnecessary_parenthesis
- unnecessary_this
- unrelated_type_equality_checks
- use_rethrow_when_possible
- unnecessary_new
2 changes: 1 addition & 1 deletion example/lib/screens/home_screen.dart
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import 'package:flutter/material.dart';
import 'package:photo_view_example/screens/common/app_bar.dart';
import 'package:photo_view_example/screens/examples/common_use_cases_examples.dart';
import 'package:photo_view_example/screens/examples/controller_example.dart';
import 'package:photo_view_example/screens/examples/custom_child_examples.dart';
import 'package:photo_view_example/screens/examples/dialog_example.dart';
import 'package:photo_view_example/screens/examples/common_use_cases_examples.dart';
import 'package:photo_view_example/screens/examples/gallery/gallery_example.dart';
import 'package:photo_view_example/screens/examples/hero_example.dart';
import 'package:photo_view_example/screens/examples/inline_examples.dart';
Expand Down
189 changes: 0 additions & 189 deletions example/pubspec.lock

This file was deleted.

1 change: 1 addition & 0 deletions lib/photo_view.dart
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,7 @@ class _PhotoViewState extends State<PhotoView>

@override
Widget build(BuildContext context) {
super.build(context);
return LayoutBuilder(
builder: (
BuildContext context,
Expand Down
1 change: 0 additions & 1 deletion lib/src/controller/photo_view_controller.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import 'dart:async';
import 'dart:ui';

import 'package:flutter/widgets.dart';
import 'package:photo_view/src/utils/ignorable_change_notifier.dart';
Expand Down
5 changes: 0 additions & 5 deletions lib/src/controller/photo_view_controller_delegate.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import 'dart:ui';

import 'package:flutter/widgets.dart';

import 'package:photo_view/photo_view.dart'
show
PhotoViewControllerBase,
Expand All @@ -11,8 +8,6 @@ import 'package:photo_view/photo_view.dart'
import 'package:photo_view/src/core/photo_view_core.dart';
import 'package:photo_view/src/photo_view_scale_state.dart';
import 'package:photo_view/src/utils/photo_view_utils.dart';
import 'package:photo_view/src/controller/photo_view_controller.dart';
import 'package:photo_view/src/controller/photo_view_scalestate_controller.dart';

/// A class to hold internal layout logic to sync both controller states
///
Expand Down
2 changes: 1 addition & 1 deletion lib/src/core/photo_view_gesture_detector.dart
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class PhotoViewGestureRecognizer extends ScaleGestureRecognizer {
Object? debugOwner,
this.validateAxis,
PointerDeviceKind? kind,
}) : super(debugOwner: debugOwner, kind: kind);
}) : super(debugOwner: debugOwner);
final HitCornersDetector? hitDetector;
final Axis? validateAxis;

Expand Down
4 changes: 3 additions & 1 deletion lib/src/photo_view_wrappers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ class _ImageWrapperState extends State<ImageWrapper> {
_lastStack = stackTrace;
});
assert(() {
if (widget.errorBuilder == null) throw error;
if (widget.errorBuilder == null) {
throw error;
}
return true;
}());
}
Expand Down
Loading

0 comments on commit c5fcfdc

Please sign in to comment.