Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network breaks down, the app will crash and get stuck when you click the picture #275

Closed
DNetORM opened this issue Apr 20, 2020 · 1 comment · Fixed by #308
Closed

network breaks down, the app will crash and get stuck when you click the picture #275

DNetORM opened this issue Apr 20, 2020 · 1 comment · Fixed by #308
Assignees
@renancaraujo
Labels
bug Something isn't working

Comments

@DNetORM
Copy link

DNetORM commented Apr 20, 2020

If the network breaks down, the app will crash and get stuck when you click the picture，The debugging found that it was caused by an exception thrown due to the download failure,
Maybe this is not the direct bug of photo view, but whether photo view can be used as a compatible network interruption scenario, so that the picture can still be clicked on, and it doesn't matter if it can't be displayed. For example, the app shouldn't crash instead of loading prompts all the time,When the image has been in loading mode, the user will realize that this is a network problem, just close it, at least the program will not crash
@zinwalin
Copy link

there's no way to close photo_view window when all pictures can't load. it's a big issue.

@renancaraujo renancaraujo self-assigned this Jul 12, 2020
@renancaraujo renancaraujo added the bug Something isn't working label Jul 12, 2020
renancaraujo pushed a commit that referenced this issue Aug 10, 2020
fix #275
637e70a
@renancaraujo renancaraujo mentioned this issue Aug 10, 2020
Merged
renancaraujo pushed a commit that referenced this issue Aug 11, 2020
fix #275
0b08f57
renancaraujo added a commit that referenced this issue Aug 11, 2020
@renancaraujo
Fix crash on network fail #275 (#308)
c9d5885 
When retrieving images from the network, things can go south.
This fixes a bug when the network goes down, photo_view would crash when retrieving remote images.

Fixes: #275
@renancaraujo renancaraujo mentioned this issue Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renancaraujo renancaraujo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash on network fail. bluefireteam/photo_view
3 participants
@zinwalin @renancaraujo @DNetORM