-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] loadFailedChild doesn't show error widget #316
Comments
firebatu
changed the title
loadfailedchild doesn't show error widget [BUG]
loadFailedChild doesn't show error widget [BUG]
Aug 16, 2020
firebatu
changed the title
loadFailedChild doesn't show error widget [BUG]
[BUG] loadFailedChild doesn't show error widget
Aug 16, 2020
renancaraujo
added a commit
that referenced
this issue
Aug 22, 2020
This makes the image retrieval process not rely on a FutureBuilder. Previously we recreated Image behavior by showing a loader whilst the image loads, using a completer to detect when the image had finished load. Now we rely only on the good old state and some ifs in the build method. Also, we have split that code from the custom child code. The main widget had logics for both image and custom child modes. Now we split that into two internal widgets, the wrappers. This should resolve the following issues #316 #303
Should be fixed on #320 |
@renancaraujo For galleries, there is no errorBuilder option. There's a reason you didn't add errorBuilder for galleries?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I use
NetworkImage
provider to fetch image from the internet. Also I use theContainer
with placeholder as an argument forloadfailedchild
, but in case of an error (Internet connection disabled) placeholder doesn't showing. I just see empty page. I noticed that this happens when usingheroAttributes
:Code snippet:
The text was updated successfully, but these errors were encountered: