Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove revision settings UI and filter #1319

Merged
merged 6 commits into from
Sep 21, 2024
Merged

Remove revision settings UI and filter #1319

merged 6 commits into from
Sep 21, 2024

Conversation

0aveRyan
Copy link
Contributor

Proposed changes

  • Hides content revisions UI
  • Removes action hook filter with limit from executing

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@earnjam earnjam mentioned this pull request Sep 21, 2024
Closed
@earnjam earnjam changed the title Hotfix: Temporarily remove revision settings UI and filter Remove revision settings UI and filter Sep 21, 2024
@earnjam
Copy link
Member

earnjam commented Sep 21, 2024

It might fail some tests. I think we have some looking for that section

@cypress Cypress
Copy link

cypress bot commented Sep 21, 2024 •
edited
Loading

Bluehost Brand Plugin    Run #10568

Run Properties:  status check passed Passed #10568  •  git commit 2520432bf3 ℹ️: Merge 7bea44fa5813d6d6d146b12f48e5312e1a638b2a into cfbd2b0542ed7dede6861a6598e0...
Project Bluehost Brand Plugin
Branch Review remove-revisions-locking-hotfix
Run status status check passed Passed #10568
Run duration 05m 39s
Commit git commit 2520432bf3 ℹ️: Merge 7bea44fa5813d6d6d146b12f48e5312e1a638b2a into cfbd2b0542ed7dede6861a6598e0...
Committer Dave Ryan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@bhwpteam bhwpteam merged commit 9cbff47 into main Sep 21, 2024
16 of 19 checks passed
@circlecube circlecube deleted the remove-revisions-locking-hotfix branch September 25, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earnjam earnjam earnjam left review comments

@bhwpteam bhwpteam bhwpteam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0aveRyan @earnjam @bhwpteam