Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update burst safety mode page to enqueue CSS rather than just echoing it #1337

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Oct 2, 2024

  • defines are moved to be able to use them in the alt-experience file and to make them fit in better with the rest
  • condensed the comments of the loading
  • enqueued the styles rather than just echoing the CSS

@bradp bradp requested a review from circlecube October 2, 2024 00:31
Copy link

cypress bot commented Oct 2, 2024

Bluehost Brand Plugin    Run #11035

Run Properties:  status check passed Passed #11035  •  git commit 655f08ec02 ℹ️: Merge 5ebfbadfa340062910c2e2040c82ef557b869566 into 70e3c4886702f6f4935e0ec4b9f6...
Project Bluehost Brand Plugin
Run status status check passed Passed #11035
Run duration 30m 32s
Commit git commit 655f08ec02 ℹ️: Merge 5ebfbadfa340062910c2e2040c82ef557b869566 into 70e3c4886702f6f4935e0ec4b9f6...
Committer Brad Parbs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416

@circlecube circlecube changed the base branch from main to develop October 3, 2024 21:44
@circlecube circlecube added this to the October 9, 2024 Release milestone Oct 3, 2024
@abhijitb abhijitb merged commit 3644393 into develop Oct 16, 2024
22 checks passed
@abhijitb abhijitb deleted the enqueue-style-for-alt-experience branch October 16, 2024 16:58
@abhijitb abhijitb mentioned this pull request Oct 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants