Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/ecommerce 1.4.4 #1422

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Update/ecommerce 1.4.4 #1422

merged 3 commits into from
Nov 20, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 changed the base branch from main to develop November 20, 2024 13:21
Copy link

cypress bot commented Nov 20, 2024

Bluehost Brand Plugin    Run #11701

Run Properties:  status check failed Failed #11701  •  git commit 2f5f095cbd ℹ️: Merge b3aa46870eb8c776788996d90be0e77860d8a226 into 1e5d2482d49320b3ec328f8da33a...
Project Bluehost Brand Plugin
Branch Review update/ecommerce-1.4.4
Run status status check failed Failed #11701
Run duration 09m 14s
Commit git commit 2f5f095cbd ℹ️: Merge b3aa46870eb8c776788996d90be0e77860d8a226 into 1e5d2482d49320b3ec328f8da33a...
Committer Arati Bhandare
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 11
Tests that passed  Passing 110
View all changes introduced in this branch ↗︎

Tests for review

Failed  coming-soon-woo.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon with WooCommerce > Replace our admin bar site status badge with WooCommerce's when active Test Replay Screenshots Video
Failed  coming-soon.cy.js • 1 failed test

View Output Video

Test Artifacts
Coming Soon > Coming Soon is active Test Replay Screenshots Video

Copy link

cypress bot commented Nov 20, 2024

Bluehost Brand Plugin    Run #11716

Run Properties:  status check passed Passed #11716  •  git commit fb2649f54e: roll back coming soon update
Project Bluehost Brand Plugin
Branch Review update/ecommerce-1.4.4
Run status status check passed Passed #11716
Run duration 30m 11s
Commit git commit fb2649f54e: roll back coming soon update
Committer Evan Mullins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 33
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 409
View all changes introduced in this branch ↗︎

* develop:
  NPM(deps): Bump @wordpress/icons from 10.11.0 to 10.12.0
  NPM(deps): Bump @wordpress/compose from 7.11.0 to 7.12.0
  NPM Dev(deps-dev): Bump tailwindcss from 3.4.14 to 3.4.15
  NPM(deps): Bump @wordpress/i18n from 5.11.0 to 5.12.0
  Composer(deps): Bump newfold-labs/wp-module-onboarding
  fix tested up to version mismatch
  Composer(deps): Bump newfold-labs/wp-module-patterns from 2.6.1 to 2.7.1
  update data module to 2.6.7 notifications 1.6.6 (test updates)
  update notifications module to 1.6.6 downgrade coming-soon (1.3.0 => 1.2.6)
  NPM(deps): Bump @wordpress/dom-ready from 4.11.0 to 4.12.0
  update modules: notifications 1.6.5 and coming soon 1.3.0
  update plugin version to 3.15.4

# Conflicts:
#	composer.lock
@circlecube
Copy link
Member

I resolved the conflicts in this PR.

@aratidgr8 - When updating a specific package in composer like this, rather than running composer update, run composer update newfold-labs/wp-module-ecommerce since it will update only that specific package rather than all available updates. This is helpful to make sure only this single module is updated so if tests fail we have a clear indication as to why and what code changes are included in this PR. Each module update should have its own PR associated.

@circlecube circlecube merged commit f2d5a7b into develop Nov 20, 2024
3 checks passed
@circlecube circlecube deleted the update/ecommerce-1.4.4 branch November 20, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants