collection of fixes #268
Merged
collection of fixes #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes $GOPATH from the beginning of the filepaths built into the object, and e.g. shown in stacktraces. The operator-sdk build is supposed to do this as well, although with our version of the operator SDK you need to backport this fix to your own local copy before building/installing it: operator-framework/operator-sdk#1535
* Minor: use spaces instead of underscores for human readability. * Major: change "ready" to "configured". This state really reflects what KD has done to set up the pod and associated objects, and doesn't say anything about for example whether the pod is crashing. All of our internal variable names still say "ready" ... I should clean those up but I'll churn them later. I'd also like to change the overall cluster state string from "ready" to "configured" but first want to check on what external things depend on that.
Error in using golang switch syntax.
Cf. bluek8s#267 To ensure this, remove the direct export of the client from the shared pkg, and instead require calling shared.Get, shared.Create, etc. For the most part those functions will call the split client, but Get will have the desired special behavior.
don-milos
approved these changes
Feb 11, 2020
swamibluedata
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes at least some amount of fixing or workaround for issue #265 and issue #267.
Each commit is its own self-contained thing with its own description. Bundling them together here for quicker testing and less build churn.
It's probably easiest to examine each commit individually, especially because 7b4744f changes a lot of files mechanically through find-and-replace (only the client.go changes in there are interesting).