fix: make get_pk_constraint adhere to SqlAlchemy specs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
approved these changes
Mar 18, 2020
|
Looks right to me! Thanks a ton, @villebro! |
|
That's awesome, thanks @vinceatbluelabs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
get_pk_constraint()returns a dict that isn't in line with the SqlAlchemy specification. As stated in the documentation,constrained_columns: a list of column names that make up the primary keyname: optional name of the primary key constraint.I.e. the columns should be a list, and the name should be the name of the primary key if it exists.
This PR casts the list of columns into a list, and assigns the name based on the first non NULL value returned for the constraint name if defined.