gcache with context #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
update readme |
|
would be great to have this change merged |
|
No tests for Context timeout/Context related functionality |
|
I didn't see a compelling need; the functional changes are almost nothing; it's mostly just plumbing |
|
For the most part I certainly agree with you, but the changes in singleflight.go (Do function) are comparatively substantial. And that would be the only place I would include additional tests. |
|
Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged. |
|
Yes, I agree….looks like the owner ditched the project…in any case, I love the code and the use case is a very common one.
… On Feb 21, 2023, at 2:30 PM, Scott Blum ***@***.***> wrote:
Fair enough. But worth noting that this PR has grown stale and needs rebase+conflict res. I'm not inclined to keep working on this PR without some indication that there's a path to getting this merged.
—
Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4FXSSOJKACVOP7S7VAHVO3WYUCSXANCNFSM4HZC2FCA>.
You are receiving this because you commented.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.