DynamicFieldType: restore TypeConverter lookup #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricKuck
added a commit
that referenced
this pull request
Mar 10, 2016
DynamicFieldType: restore TypeConverter lookup
|
Thanks @talklittle! Will be releasing an update that includes this within a few hours. |
EricKuck
added a commit
that referenced
this pull request
Mar 10, 2016
|
I actually ended up reverting this PR and fixing it a different way. Since creating TypeConverters can theoretically be expensive, the new change in 1.3.7 should ensure that they're only ever created once. If you have any issues with 1.3.7 vs. 1.3.6, please let me know. |
|
@EricKuck Thanks! 1.3.7 works great. Tested with ProGuard also. |
bluef
pushed a commit
to bluef/LoganSquare
that referenced
this pull request
Oct 11, 2016
* master: able to create fatjar Reverted bluelinelabs#144 and fixed the issue another way. Also version bumped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed between LoganSquare 1.3.3 and 1.3.4.
Reverting this change fixes the compile-time error.
fixes GH-118