Add emblem for connected state #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yeah, this is a reasonable approach for now. I think the icon is fine so ok with me. |
infirit
approved these changes
Oct 18, 2022
|
Still not satisfied with this, but I tend to merge it to go on with #1642. Maybe @clefebvre, you'd want to have a more artistic look at this? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could solve the problem mentioned in #1642 as an alternative to the #1620 concept.
I think it's fair to just use the spot of the "paired" emblem and override it with the "connected" emblem. It's not very distinguishable right now, though. One might probably want a different color for it.
The icon's content is basically stolen from Adwaita.