Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez.Base: Don't subclass from Gio.DBusProxy #2009

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Jan 15, 2023

So we can get to the invalidated properties.

Base will now add the list of invalidated properties like this.

Base:67 __properties_changed: /org/bluez/hci0/dev_76_DD_19_54_A8_42 {} ['TxPower', 'RSSI'] <Device.Device object at 0x7f777e155e80 (blueman+bluez+Device+Device at 0x55ef15d47da0)>

@infirit
Copy link
Contributor Author

infirit commented Jan 16, 2023

Wait, I just realized I did property-changed in two ways. It should be at least consistent between them.

I am leaning to key, None so we can check the value and if it's None then it's invalidated. But sending the list is also fine with me.

@cschramm
Copy link
Member

I am leaning to key, None so we can check the value and if it's None then it's invalidated.

That would make perfect sense to me. 👍

@infirit
Copy link
Contributor Author

infirit commented Jan 16, 2023

Updated and also slightly changed how it emit's the signal.

So we can get to the invalidated properties.
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

blueman/bluez/Base.py Show resolved Hide resolved
@infirit infirit merged commit cac95f8 into blueman-project:main Jan 27, 2023
@infirit infirit deleted the invalidated branch January 27, 2023 16:38
@cschramm cschramm mentioned this pull request Nov 25, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants