-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use small toolbar size and text beside icons #2231
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Just to be sure as I see no device address, you removed them from the screenshot? Changes look OK to me but I will have a better look later this week and test it on various themes. |
Yes I only changed the toolbar UI file and replaced the icon_widget prop of the Trust Tool button with an icon_name instead on the python side |
Had a better look and the toolbar looks a bit better, but... It exposes an alignment and spacing issue with the Trust button label due to how we force a specific size to avoid buttons moving within the toolbar when the label text is updated (see screenshot 1). Fixing the alignment is easy if we have direct access to the label widget by setting the I did a quick experiment setting The reason it looks like this for me as in Dutch there is no short translation for "Untrust", "Vertrouwen beëindigen". I suspect it's similar in other languages. The buttons jumping around in the toolbar is distracting and annoying so that's not an option. Not sure how to move forward with this at the moment... |
How about making that button/group the last one on the toolbar? |
Another thought is to use a toggle button to represent the state of "Trust" |
Hey there, it's been a while. Any chances of at least getting the small toolbar icon size changes in? The icons look a bit too big compared to the text next to them |
Text can help new users identify actions easily and since there are few toolbar items i don't think space will be a problem with languages like Russian