Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use small toolbar size and text beside icons #2231

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axel358
Copy link

@axel358 axel358 commented Dec 29, 2023

Screenshot from 2023-12-29 09-49-01
Text can help new users identify actions easily and since there are few toolbar items i don't think space will be a problem with languages like Russian

Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cschramm cschramm requested a review from infirit January 1, 2024 10:45
@infirit
Copy link
Contributor

infirit commented Jan 2, 2024

Just to be sure as I see no device address, you removed them from the screenshot?

Changes look OK to me but I will have a better look later this week and test it on various themes.

@axel358
Copy link
Author

axel358 commented Jan 3, 2024

Yes I only changed the toolbar UI file and replaced the icon_widget prop of the Trust Tool button with an icon_name instead on the python side

@infirit
Copy link
Contributor

infirit commented Jan 5, 2024

Had a better look and the toolbar looks a bit better, but... It exposes an alignment and spacing issue with the Trust button label due to how we force a specific size to avoid buttons moving within the toolbar when the label text is updated (see screenshot 1).

Fixing the alignment is easy if we have direct access to the label widget by setting the xalign property to 0. But we don't and I would prefer to avoid fetching it from the container. But even with setting xalign we have a lot of ugly empty space in the button.

I did a quick experiment setting xalign and a different way of forcing the size but it looks worse (see 2nd screenshot). I get the feeling this is why blueman only shows an icon 😅 .

The reason it looks like this for me as in Dutch there is no short translation for "Untrust", "Vertrouwen beëindigen". I suspect it's similar in other languages.

The buttons jumping around in the toolbar is distracting and annoying so that's not an option. Not sure how to move forward with this at the moment...

image

image

@axel358
Copy link
Author

axel358 commented Jan 5, 2024

How about making that button/group the last one on the toolbar?

@axel358
Copy link
Author

axel358 commented Jan 18, 2024

Another thought is to use a toggle button to represent the state of "Trust"

@axel358
Copy link
Author

axel358 commented Oct 30, 2024

Hey there, it's been a while. Any chances of at least getting the small toolbar icon size changes in? The icons look a bit too big compared to the text next to them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants