Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

muxer: fix nil deref when finalizing muxerSegmentFMP4 with no currentPart #136

Closed
wants to merge 1 commit into from
Closed

muxer: fix nil deref when finalizing muxerSegmentFMP4 with no currentPart #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions muxer_segment_fmp4.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@
}

func (s *muxerSegmentFMP4) finalize(nextDTS time.Duration) error {
if s.currentPart == nil {
return nil
}

Check warning on line 85 in muxer_segment_fmp4.go

View check run for this annotation

Codecov / codecov/patch

muxer_segment_fmp4.go#L84-L85 

Added lines #L84 - L85 were not covered by tests

if s.currentPart.videoSamples != nil || s.currentPart.audioSamples != nil {
err := s.currentPart.finalize(nextDTS)
if err != nil {
Expand Down
Loading