Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore LL-HLS requests for segments that have already expired #156

Merged
merged 2 commits into from
May 12, 2024

Conversation

HyeockJinKim
Copy link
Contributor

If an LL-HLS request comes in for a segment that has already expired, it will always wait until the session is terminated.
If the segment is already in an inaccessible state, it is handled so that it does not wait any longer.

@HyeockJinKim
Copy link
Contributor Author

Can I get a review? @aler9

@aler9
Copy link
Member

aler9 commented May 11, 2024

Hello, this seems ok to me, fix the lint errors and the patch will get merged.

Tests are ok, although i usually write them by using public methods only ("black box approach") in order to assess the visibility of the tested feature from the outside and also to avoid to directly use private members or methods, since these can change over time. Therefore, instead of mockSegmentMP4 i would have used WriteH26x() multiple times in order to generate those mock segments. But this is just a detail, not mandatory in any way.

@HyeockJinKim
Copy link
Contributor Author

I fixed lint error in testcode.

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (8387829) to head (81329de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   71.59%   72.22%   +0.62%     
==========================================
  Files          57       57              
  Lines        3985     3985              
==========================================
+ Hits         2853     2878      +25     
+ Misses        924      899      -25     
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 6a11488 into bluenviron:main May 12, 2024
8 checks passed
@aler9
Copy link
Member

aler9 commented May 12, 2024

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants