Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MPEG2 Layer2 #486

Closed
amirvalhalla opened this issue Dec 16, 2023 · 5 comments
Closed

Support MPEG2 Layer2 #486

amirvalhalla opened this issue Dec 16, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@amirvalhalla
Copy link

Hi,

I've been working with your awesome package, and it works well for most of audio/video codecs. However, I've encountered a challenge as I'm currently looking to decode MPEG2 Layer2, which unfortunately the package doesn't support. I'm curious if there's a specific reason for not supporting MPEG2 Layer2 and if there are any plans to include support for it in the future.

Thank you!

@aler9
Copy link
Member

aler9 commented Dec 16, 2023

Hello, there is no particular reason for not supporting MPEG-2 layer 2 (by the way, this limitation lies in mediacommon and not in gortsplib, which is already fit for handling any MPEG combination), other than the fact that this feature wasn't requested until now. Just provide a sample MPEG-2 layer 2 file or a FFmpeg / GStreamer command that allows to generate it and i'll add support for it.

@aler9 aler9 added the enhancement New feature or request label Dec 16, 2023
@amirvalhalla
Copy link
Author

Hello, there is no particular reason for not supporting MPEG-2 layer 2 (by the way, this limitation lies in mediacommon and not in gortsplib, which is already fit for handling any MPEG combination), other than the fact that this feature wasn't requested until now. Just provide a sample MPEG-2 layer 2 file or a FFmpeg / GStreamer command that allows to generate it and i'll add support for it.

Okay, I'll provide the 'command' or a sample 'MPEG-2 layer2' file and come back to you.

@amirvalhalla
Copy link
Author

@aler9
you can use below command to simulate MPEG2-Layer2.

ffmpeg -i noise.wav -c:a mp2 -b:a 192k output.mp2

aler9 added a commit to bluenviron/mediacommon that referenced this issue Jan 19, 2024
aler9 added a commit to bluenviron/mediacommon that referenced this issue Jan 19, 2024
@aler9
Copy link
Member

aler9 commented Jan 19, 2024

fixed in mediacommon v1.9.0

Copy link

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants