webrtc: support WHIP/WHEP endpoints without PATCH support (#3273) (#3277

)
bluenviron · Apr 20, 2024 · bfa83fc · bfa83fc
1 parent 4ed1a39
commit bfa83fc
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/internal/protocols/webrtc/whip_client.go b/internal/protocols/webrtc/whip_client.go
@@ -23,7 +23,8 @@ type WHIPClient struct {
 	URL        *url.URL
 	Log        logger.Writer
 
-	pc *PeerConnection
+	pc               *PeerConnection
+	patchIsSupported bool
 }
 
 // Publish publishes tracks.
@@ -290,10 +291,7 @@ func (c *WHIPClient) postOffer(
 		return nil, fmt.Errorf("bad Content-Type: expected 'application/sdp', got '%s'", contentType)
 	}
 
-	acceptPatch := res.Header.Get("Accept-Patch")
-	if acceptPatch != "application/trickle-ice-sdpfrag" {
-		return nil, fmt.Errorf("wrong Accept-Patch: expected 'application/trickle-ice-sdpfrag', got '%s'", acceptPatch)
-	}
+	c.patchIsSupported = (res.Header.Get("Accept-Patch") == "application/trickle-ice-sdpfrag")
 
 	Location := res.Header.Get("Location")
 
@@ -325,6 +323,10 @@ func (c *WHIPClient) patchCandidate(
 	etag string,
 	candidate *webrtc.ICECandidateInit,
 ) error {
+	if !c.patchIsSupported {
+		return nil
+	}
+
 	frag, err := ICEFragmentMarshal(offer.SDP, []*webrtc.ICECandidateInit{candidate})
 	if err != nil {
 		return err