Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page query parameter not working properly for non-existent page number #2604

Closed
1 of 13 tasks
tbnguyen1407 opened this issue Oct 30, 2023 · 2 comments · Fixed by #2614
Closed
1 of 13 tasks

Page query parameter not working properly for non-existent page number #2604

tbnguyen1407 opened this issue Oct 30, 2023 · 2 comments · Fixed by #2614
Labels
api hooks external auth bug Something isn't working

Comments

@tbnguyen1407
Copy link

tbnguyen1407 commented Oct 30, 2023

Which version are you using?

v1.2.1

Which operating system are you using?

  • Linux amd64 standard
  • Linux amd64 Docker
  • Linux arm64 standard
  • Linux arm64 Docker
  • Linux arm7 standard
  • Linux arm7 Docker
  • Linux arm6 standard
  • Linux arm6 Docker
  • Windows amd64 standard
  • Windows amd64 Docker (WSL backend)
  • macOS amd64 standard
  • macOS amd64 Docker
  • Other (please describe)

Describe the issue

Results of last page is always returned when calling API with non-existent page number (page >= pageCount).

Describe how to replicate the issue

  1. add 3 paths (path1, path2, path3)
  2. start servers
  3. call API /v3/paths/list?page=X&itemsPerPage=2
## pageCount = 2
page=0: return path1, path2  ## correct
page=1: return path3         ## correct
page=2: return path3         ## incorrect, should be empty
page=3: return path3         ## incorrect, should be empty
...

Did you attach the server logs?

no

Did you attach a network dump?

no

Copy link
Contributor

This issue is mentioned in release v1.3.0 🚀
Check out the entire changelog by clicking here

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api hooks external auth bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants