Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webrtcHandshakeTimeout and webrtcTrackGatherTimeout configurable #3404

Closed
jwalton opened this issue May 28, 2024 · 3 comments
Closed

Make webrtcHandshakeTimeout and webrtcTrackGatherTimeout configurable #3404

jwalton opened this issue May 28, 2024 · 3 comments

Comments

@jwalton
Copy link
Contributor

jwalton commented May 28, 2024

Describe the feature

I'm running into an issue where my WebRTC client is taking a little too long to complete the timeout. We end up hitting the webrtcHandshakeTimeout, which kills the connection, then my client tries again, but fails again, and we end up in this loop of doom never playing video, but it could be solved if we could bump up the timeout a little.

So I'd like to raise a PR to make this configurable, but I'm wondering if you would prefer to see these added to the Path struct (so they could be configured per-path) or to the top level Conf struct? I'm inclined towards the Conf struct, as it seems unlikely anyone would ever want to configure these path-by-path.

jwalton added a commit to SolinkCorp/mediamtx that referenced this issue May 28, 2024
jwalton added a commit to SolinkCorp/mediamtx that referenced this issue May 28, 2024
jwalton added a commit to SolinkCorp/mediamtx that referenced this issue May 28, 2024
jwalton added a commit to SolinkCorp/mediamtx that referenced this issue May 29, 2024
aler9 pushed a commit that referenced this issue May 30, 2024
* webrtc: allow configuring timeouts (#3404)

* fix from code inspect
@aler9
Copy link
Member

aler9 commented May 30, 2024

fixed by #3406

Copy link
Contributor

This issue is mentioned in release v1.8.3 🚀
Check out the entire changelog by clicking here

Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants