Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MTX_QUERY from WHIP request URL available in runOnReady hook #3937

Closed
dmitritz opened this issue Nov 6, 2024 · 2 comments · Fixed by #4141
Closed

Make MTX_QUERY from WHIP request URL available in runOnReady hook #3937

dmitritz opened this issue Nov 6, 2024 · 2 comments · Fixed by #4141

Comments

@dmitritz
Copy link

dmitritz commented Nov 6, 2024

Describe the feature

The documentation on runOnReady hook https://github.com/bluenviron/mediamtx/blob/main/README.md#hooks specifies that the MTX_QUERY should be available:

# * MTX_QUERY: query parameters (passed by publisher)

But they are not for a WHIP stream.
Shouldn't they be passed from the initial WHIP session initiation request?
Because this is how a producer can communicate any meta-information about a stream.
Proposition: get the query parameters from a WHIP request URL and store them as the producer's query parameters accessible in the hooks

@aler9
Copy link
Member

aler9 commented Jan 11, 2025

Thanks for reporting the issue, this is fixed by #4141

Copy link
Contributor

This issue is mentioned in release v1.11.1 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants