Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default value of some settings #2367

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix default value of some settings #2367

merged 1 commit into from
Sep 19, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 19, 2023

rtmpServerKey, rtmpServerCert, recordPath, rpiCameraExposure, rpiCameraAWB, rpiCameraDenoise, rpiCameraMetering, rpiCameraAfMode, rpiCameraAfRange, rpiCameraAfSpeed were not set correctly when missing in the configuration file.

rtmpServerKey, rtmpServerCert, recordPath, rpiCameraExposure,
rpiCameraAWB, rpiCameraDenoise, rpiCameraMetering, rpiCameraAfMode,
rpiCameraAfRange, rpiCameraAfSpeed were not set correctly when missing
in the configuration file.
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2367 (ca4757d) into main (7ca2571) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
+ Coverage   60.93%   61.36%   +0.42%     
==========================================
  Files         127      127              
  Lines       14527    14537      +10     
==========================================
+ Hits         8852     8920      +68     
+ Misses       5021     4951      -70     
- Partials      654      666      +12     
Files Changed Coverage Δ
internal/conf/conf.go 75.86% <100.00%> (+0.31%) ⬆️
internal/conf/path.go 27.73% <100.00%> (+3.05%) ⬆️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit b86dc97 into main Sep 19, 2023
8 checks passed
@aler9 aler9 deleted the bug/conf branch September 19, 2023 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant