Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix ETag header name according to specification (#2396) #2401

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Sep 23, 2023

Fixes #2396

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2401 (a2df58f) into main (75f518a) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2401      +/-   ##
==========================================
+ Coverage   61.61%   61.63%   +0.02%     
==========================================
  Files         129      129              
  Lines       14476    14476              
==========================================
+ Hits         8919     8923       +4     
+ Misses       4883     4880       -3     
+ Partials      674      673       -1     
Files Changed Coverage Δ
internal/whip/post_offer.go 0.00% <0.00%> (ø)
internal/core/webrtc_http_server.go 57.74% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit f1e28d0 into main Sep 23, 2023
7 of 8 checks passed
@aler9 aler9 deleted the bug/etag branch September 23, 2023 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WHEP - ETag header is E-Tag
1 participant